New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing parentheses #12875
Add missing parentheses #12875
Conversation
Logical not is applied to int type, which is clearly a mistake. Add the missing parentheses to apply it for the comparison. Validation/MuonGEMRecHits/src/GEMRecHitsValidation.cc:127:39: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] Validation/MuonGEMRecHits/src/GEMRecHitsValidation.cc:127:39: warning: comparison of constant '13' with boolean expression is always false [-Wbool-compare] Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_8_0_X. It involves the following packages: Validation/MuonGEMRecHits @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
ping^1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Logical not is applied to int type, which is clearly a mistake. Add the
missing parentheses to apply it for the comparison.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch