Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with weird linking case crashing reprocessing #12930

Merged
merged 1 commit into from Jan 14, 2016

Conversation

bachtis
Copy link
Contributor

@bachtis bachtis commented Jan 13, 2016

There are some extreme cases where the track is propagated to the HCAL barrel entrance and then to the HCAL endcap case . It can happen to loopers . In this case an exception was thrown in linking . NOw we link those specific tracks as well but only using the first point they did hit ignoring the exit point . Ignoring the exit point just results in more strict linking which doesnt really matter because those are really low pt tracks.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bachtis (Michalis Bachtis) for CMSSW_7_6_X.

It involves the following packages:

RecoParticleFlow/PFProducer
RecoParticleFlow/PFTracking

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor

slava77 commented Jan 13, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10481/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 13, 2016

@bachtis please make a PR for 75X as well

@bachtis
Copy link
Contributor Author

bachtis commented Jan 13, 2016

OK @slava77 tomorrow will do

@slava77
Copy link
Contributor

slava77 commented Jan 14, 2016

+1

for #12930 daaebab

  • minimal fix to crashes reported in https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1411.html; only events that would otherwise have the exception thrown are affected (recovered)
  • based on local tests, crash reported in event 259686:156976082 is now gone and in this event we get two warnings (expected) for this special case
  • jenkins tests pass and comparisons with baseline show no differences as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 14, 2016
Fix issue with weird linking case crashing reprocessing
@cmsbuild cmsbuild merged commit 4e8b383 into cms-sw:CMSSW_7_6_X Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants