New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastSim BugFix : PreMix : fix segfault, fix L1 reco, fix digisim link for muons, fix track validation #13125
Conversation
A new Pull Request was created by @lveldere for CMSSW_8_0_X. It involves the following packages: Configuration/Applications @civanch, @lveldere, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @ssekmen, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 |
+1 |
FastSim BugFix : PreMix : fix segfault, fix L1 reco, fix digisim link for muons, fix track validation
replaces #13071, #13110
Lots of fixes in one pr, but they are all entangled
Fix L1 reco, fix seg fault in premix relvals
FastSim no longer runs
SLHCUpgradeSimulations/Configuration/postLS1CustomsPreMixing.customisePostLS1
because it overwrites modification defined in the fastsim era and the run2 eras
New EDAlias for caloStage1LegacyFormatDigis to make the l1extraParticles function properly.
Note: FullSim still runs SLHCUpgradeSimulations/Configuration/postLS1CustomsPreMixing.customisePostLS1 in the DIGI step.
At some point also FullSim should move away from this.
Fix digi-sim links for muons
FastSim now runs
SimGeneral/DataMixingModule/customiseForPremixingInput.customiseForPreMixingInput
This customisation function should not affect anything but validation and dqm,
and the customisation function was modified accordingly.
Note: FullSim had never trouble with this because there the customisation function is only applied on the RECO,VALIDATION,DQM jobs.
Fix track validation
Thanks to SimGeneral/DataMixingModule/customiseForPremixingInput.customiseForPreMixingInput, the tracking particle collection should now include PU tracks