Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New HLT L1T seed filter for 2016 run (80x) #13166

Merged
merged 24 commits into from Feb 10, 2016
Merged

New HLT L1T seed filter for 2016 run (80x) #13166

merged 24 commits into from Feb 10, 2016

Conversation

mulhearn
Copy link
Contributor

@mulhearn mulhearn commented Feb 2, 2016

This adds the new HLTL1TSeeds filter module, and supporting code, the other L1T PRs in the queue. This PR will get smaller as other PRs are merged. The incremental files changed in this PR are:

mulhearn@lxplus0065>git diff --name-only 9427480bb95139d731cc08ed2487688f1dbed334..1a00c8a1ba003dadd9722908f7f3854e07d9c5c9
DataFormats/HLTReco/interface/TriggerFilterObjectWithRefs.h
DataFormats/HLTReco/interface/TriggerRefsCollections.h
DataFormats/HLTReco/src/classes_def.xml
DataFormats/L1GlobalTrigger/interface/L1GlobalTriggerObjectMap.h
DataFormats/L1GlobalTrigger/src/classes_def.xml
DataFormats/L1TGlobal/src/classes_def.xml
EventFilter/RawDataCollector/python/rawDataCollectorByLabel_cfi.py
HLTrigger/HLTfilters/interface/HLTL1TSeed.h
HLTrigger/HLTfilters/src/HLTL1TSeed.cc
HLTrigger/HLTfilters/test/devHLT_Stage2.py
L1Trigger/L1TCommon/test/devHLT.py
L1Trigger/L1TGlobal/src/GtBoard.cc

@mulhearn mulhearn mentioned this pull request Feb 2, 2016
Closed
@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Feb 2, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2016

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

CondCore/L1TPlugins
CondCore/Utilities
CondFormats/DataRecord
CondFormats/L1TObjects
DataFormats/HLTReco
DataFormats/L1DTTrackFinder
DataFormats/L1GlobalTrigger
DataFormats/L1TGlobal
DataFormats/L1TMuon
DataFormats/L1Trigger
EventFilter/L1TRawToDigi
EventFilter/RawDataCollector
HLTrigger/HLTfilters
L1Trigger/HardwareValidation
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon
L1Trigger/L1TGlobal

The following packages do not have a category, yet:

DataFormats/L1TMuon

@perrotta, @cmsbuild, @diguida, @emeschi, @cerminar, @Martin-Grunewald, @ggovi, @franzoni, @fwyzard, @mommsen, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 2, 2016

@Martin-Grunewald latest commits of rekovic included now to. These change:

mulhearn@lxplus0068>git diff --name-only 9427480bb95139d731cc08ed2487688f1dbed334
DataFormats/HLTReco/interface/TriggerFilterObjectWithRefs.h
DataFormats/HLTReco/interface/TriggerRefsCollections.h
DataFormats/HLTReco/src/classes_def.xml

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 2, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10956/console

@Martin-Grunewald
Copy link
Contributor

@mulhearn
Hmm, this is weird: TriggerFilterObjectWithRefs.h has no changes anymore (which is fine),
but still a different classversion. This can't be!

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2016

-1

Tested at: 33792e2
I found errors in the following unit tests:

---> test testSerializationL1TObjects had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13166/10956/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13166/10956/summary.html

Martin-Grunewald
Martin-Grunewald reviewed Feb 3, 2016
View reviewed changes
DataFormats/HLTReco/src/classes_def.xml
@@ -21,7 +21,6 @@
<class name="std::vector<HLTPerformanceInfo::Module>::const_iterator"/>

<class name="HLTPerformanceInfo::Path" ClassVersion="11">
<version ClassVersion="10" checksum="3100415018"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't remove a class version as it has been used. You can only add (or remove those which you
know have not been used, as those intermediate ones below)

@Martin-Grunewald
Copy link
Contributor

What is the plan to get this in for pre6?

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 4, 2016

I'm not rebasing this until more of the underlying PRs are approved...

@davidlt
Copy link
Contributor

davidlt commented Feb 7, 2016

I tried building it myself on one of those lxplus machines and everything exploded.

@davidlt
Copy link
Contributor

davidlt commented Feb 7, 2016

In my case it couldn't open /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/lcg/root/6.06.00-agmdcp/include/TStorage.h, which work just fine with editor.

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 7, 2016

Same here... Also I've compiled four different times with no changes (in PR anyway) and gotten four different answers.

@Martin-Grunewald
Copy link
Contributor

In my case it compiles (and, so far, runs TSG tests) fine but I am using a non-lxplus slc6 node. Perhaps the sw repository used is different, the afs client/server/cache is corrupted for lxplus nodes?

@davidlt
Copy link
Contributor

davidlt commented Feb 7, 2016

When you are compiling locally are you using CMSSW from AFS or CVMFS?

@Martin-Grunewald
Copy link
Contributor

afs:

echo $CMSSW_RELEASE_BASE /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-06-2300

@smuzaffar
Copy link
Contributor

OK, I have forced it to run on one of our build machines cmsbuild05. Lets see if this works

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2016

+1
Tested at: 135055e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13166/11052/summary.html

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13166/11052/summary.html

This was referenced Feb 9, 2016
Closed
Closed
@Martin-Grunewald Martin-Grunewald mentioned this pull request Feb 10, 2016
Closed
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 10, 2016
@cmsbuild
Merge pull request #13166 from cms-l1t-offline/pr-l1t-hltseeds-80x
b4d6124 
New HLT L1T seed filter for 2016 run (80x)
@cmsbuild cmsbuild merged commit b4d6124 into cms-sw:CMSSW_8_0_X Feb 10, 2016
@mulhearn mulhearn deleted the pr-l1t-hltseeds-80x branch February 11, 2016 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mulhearn @cmsbuild @Martin-Grunewald @davidlange6 @davidlt @smuzaffar @rekovic