-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New HLT L1T seed filter for 2016 run (80x) #13166
New HLT L1T seed filter for 2016 run (80x) #13166
Conversation
A new Pull Request was created by @mulhearn for CMSSW_8_0_X. It involves the following packages: CondCore/L1TPlugins The following packages do not have a category, yet: DataFormats/L1TMuon @perrotta, @cmsbuild, @diguida, @emeschi, @cerminar, @Martin-Grunewald, @ggovi, @franzoni, @fwyzard, @mommsen, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@Martin-Grunewald latest commits of rekovic included now to. These change:
|
please test |
The tests are being triggered in jenkins. |
@mulhearn |
-1 Tested at: 33792e2 ---> test testSerializationL1TObjects had ERRORS you can see the results of the tests here: |
@@ -21,7 +21,6 @@ | |||
<class name="std::vector<HLTPerformanceInfo::Module>::const_iterator"/> | |||
|
|||
<class name="HLTPerformanceInfo::Path" ClassVersion="11"> | |||
<version ClassVersion="10" checksum="3100415018"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't remove a class version as it has been used. You can only add (or remove those which you
know have not been used, as those intermediate ones below)
What is the plan to get this in for pre6? |
I'm not rebasing this until more of the underlying PRs are approved... |
33792e2
to
6cbe0ab
Compare
I tried building it myself on one of those lxplus machines and everything exploded. |
In my case it couldn't open |
Same here... Also I've compiled four different times with no changes (in PR anyway) and gotten four different answers. |
In my case it compiles (and, so far, runs TSG tests) fine but I am using a non-lxplus slc6 node. Perhaps the sw repository used is different, the afs client/server/cache is corrupted for lxplus nodes? |
When you are compiling locally are you using CMSSW from AFS or CVMFS? |
afs:
|
OK, I have forced it to run on one of our build machines cmsbuild05. Lets see if this works |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
New HLT L1T seed filter for 2016 run (80x)
This adds the new HLTL1TSeeds filter module, and supporting code, the other L1T PRs in the queue. This PR will get smaller as other PRs are merged. The incremental files changed in this PR are: