Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hit Skipping in Track Candidate producer #13214

Merged
merged 4 commits into from Feb 10, 2016
Merged

Hit Skipping in Track Candidate producer #13214

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2e3605
Implemented hit Skipping in TCP
a-kapoor Feb 6, 2016
9d12e73
Update TrackCandidateProducer.cc
a-kapoor Feb 8, 2016
88b3f7b
Debugging: Solved a crash
a-kapoor Feb 9, 2016
634fbc3
Fixed Typo
a-kapoor Feb 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 21 additions & 13 deletions FastSimulation/Tracking/plugins/TrackCandidateProducer.cc
View file
Open in desktop
Expand Up @@ -147,9 +147,27 @@ TrackCandidateProducer::produce(edm::Event& e, const edm::EventSetup& es) {
// select hits, temporarily store as TrajectorySeedHitCandidates
std::vector<TrajectorySeedHitCandidate> recHitCandidates;
TrajectorySeedHitCandidate recHitCandidate;
unsigned numberOfCrossedLayers = 0;
TrajectorySeed::range seedHitRange = seed.recHits();//Hits in a seed
for (TrajectorySeed::const_iterator ihit = seedHitRange.first; ihit != seedHitRange.second; ++ihit) {
TrajectorySeedHitCandidate seedHit=TrajectorySeedHitCandidate((const FastTrackerRecHit*)(&*ihit),
trackerGeometry.product(),trackerTopology.product());
recHitCandidates.push_back(seedHit);
}
bool passedLastSeedHit = false;

for (const auto & _hit : recHitCombination) {

TrajectorySeedHitCandidate currentTrackerHit=TrajectorySeedHitCandidate(_hit.get(),trackerGeometry.product(),trackerTopology.product());
if(seed.nHits()==0)passedLastSeedHit=true;

if(!passedLastSeedHit)
{
const FastTrackerRecHit * lastSeedHit = recHitCandidates.back().hit();
if(seed.nHits()==0||lastSeedHit->sameId(currentTrackerHit.hit()))
{
passedLastSeedHit=true;
}
continue;
}

// apply hit masking
if(hitMaskHelper
Expand All @@ -158,10 +176,6 @@ TrackCandidateProducer::produce(edm::Event& e, const edm::EventSetup& es) {
}

recHitCandidate = TrajectorySeedHitCandidate(_hit.get(),trackerGeometry.product(),trackerTopology.product());
if ( recHitCandidates.size() == 0 || !recHitCandidate.isOnTheSameLayer(recHitCandidates.back()) ) {
++numberOfCrossedLayers;
}

// hit selection
// - always select first hit
if( recHitCandidates.size() == 0 ) {
Expand All @@ -185,12 +199,6 @@ TrackCandidateProducer::produce(edm::Event& e, const edm::EventSetup& es) {
}
}

// TODO: verify it makes sense to have this selection
if ( numberOfCrossedLayers < minNumberOfCrossedLayers ) {
continue;
}


// order hits along the seed direction
bool oiSeed = seed.direction()==oppositeToMomentum;
if (oiSeed)
Expand Down Expand Up @@ -227,7 +235,7 @@ TrackCandidateProducer::produce(edm::Event& e, const edm::EventSetup& es) {
// add track candidate to output collection
output->push_back(TrackCandidate(trackRecHits,seed,PTSOD,edm::RefToBase<TrajectorySeed>(seeds,seednr)));

}
}
}

// Save the track candidates
Expand Down