Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ep combination protection #13279

Merged

Conversation

rafaellopesdesa
Copy link
Contributor

The W' group reported that the electron Ep combination was returning unphysical values at high energies when the track pT was consistent with 0. We added a protection in the combination code to only use the Ep combination MVA at high energies when the track pT error is smaller than 10 times the track pT. It is a pretty safe cut that removes these badly measured tracks from the determination of the electron energy.

Reference: https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3446/1/1/1/1.html

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rafaellopesdesa (Rafael Lopes de Sa) for CMSSW_8_0_X.

It involves the following packages:

EgammaAnalysis/ElectronTools

@cmsbuild, @vadler, @davidlange6, @monttj can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@fcouderc
Copy link
Contributor

@cmsbuild please test

@slava77
Copy link
Contributor

slava77 commented Feb 15, 2016

@cmsbuild please test

@fcouderc , since jenkins testing is a limited resource, there is also a limited list of people to trigger the tests

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11224/console

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 15, 2016

@cmsbuild please test
the comparison job failed

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11233/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@rafaellopesdesa
Copy link
Contributor Author

Hi,

I don't fully understand the result. Looking at the DQM comparison, I see
differences in HcalHitsV, but that doesn't make much sense given that the
only modification was on very high level EGamma code. Is that something
expected?

Thanks,
-- Rafael.

On Mon, Feb 15, 2016 at 9:12 PM, cmsbuild notifications@github.com wrote:

Comparison is ready

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13279/11233/summary.html


Reply to this email directly or view it on GitHub
#13279 (comment).

@davidlange6
Copy link
Contributor

Is a bug in Dqm for fast sim.

davidlange6 added a commit that referenced this pull request Feb 16, 2016
@davidlange6 davidlange6 merged commit e244d07 into cms-sw:CMSSW_8_0_X Feb 16, 2016
@rafaellopesdesa rafaellopesdesa deleted the EPcombination_protection branch February 1, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants