Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ep protection at high energy against crazy tracks .. RECO part #13302

Merged

Conversation

rafaellopesdesa
Copy link
Contributor

Similar to #13279 , but also in reco part (the reason I am submitting as a different PR is that some of the analysis PR have been already merged).

The W' group reported that the electron Ep combination was returning unphysical values at high energies when the track pT was consistent with 0. We added a protection in the combination code to only use the Ep combination MVA at high energies when the track pT error is smaller than 10 times the track pT. It is a pretty safe cut that removes these badly measured tracks from the determination of the electron energy.

Reference: https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3446/1/1/1/1.html

att: @fcouderc @matteosan1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rafaellopesdesa (Rafael Lopes de Sa) for CMSSW_8_0_X.

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11249/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 17, 2016

+1

for #13302 975aaad

  • changes in the code are in line with the description; the reco electrons energy is protected from large/bad inputs.
  • jenkins tests pass and comparisons with baseline show no differences (the phase space of the fix is rather small)
  • local tests (in CMSSW_8_0_X_2016-02-11-1100) show some differences in larger samples, mainly at high-pt for electrons and the downstream objects (pf electrons, jets, MET).

Here are some simple examples from 1316 (1 TeV electron gun with run2 setup)
pf electron pt is peaking slightly better at 1 TeV
all_sign669vsorig_singleelectron13pt1000wf1316p0c_log10recopfcandidates_particleflow__reco_obj_pt20
the tails at high values are much smaller in general
wf1316_elepovergen_vseta
and the reconstructed momentum is better for the showering electrons more noticeably than for other electrons
wf1316_eleshowering_popgen

MET is smaller on average
all_sign669vsorig_singleelectron13pt1000wf1316p0c_log10recopfmets_pfmet__reco_obj_pt
and MET sumEt doesn't have an extra bump
all_sign669vsorig_singleelectron13pt1000wf1316p0c_log10recopfmets_pfmet__reco_obj_sumet

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 17, 2016
…on_reco_80

Ep protection at high energy against crazy tracks .. RECO part
@cmsbuild cmsbuild merged commit d2402ff into cms-sw:CMSSW_8_0_X Feb 17, 2016
@rafaellopesdesa rafaellopesdesa deleted the EPcombination_protection_reco_80 branch February 1, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants