Isolation CITK 80X (rebased)

[ishvetso]

update for CITK isolation module in 76X: included puppi-based isolation, map based veto (electron and photon) and cone veto (photons)

[cmsbuild]

A new Pull Request was created by @ishvetso (Ivan Shvetsov) for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/IsolationAlgos
RecoEgamma/EgammaIsolationAlgos

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11345/console

[cmsbuild]

+1
Tested at: 67ba1c8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13391/11345/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
67ba1c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13391/11345/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13391/11345/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13391/11345/summary.html

[slava77]

please remove this line. It is a duplicate in 80X version.

[cmsbuild]

Pull request #13391 was updated. @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11351/console

[cmsbuild]

-1
Tested at: b45d01a
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13391/11351/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4962138
67ba1c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13391/11351/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13391/11351/git-merge-result

[slava77]

another (less) broken IB, sigh.

[slava77]

+1

for #13391 b45d01a

• code changes are OK, the same as in 74X version. All new code for use in analysis.
• jenkins tests pass where needed (compilation and code quality checks)

[davidlange6]

this time from code that passed all checks.. backing it out

On Feb 18, 2016, at 9:47 PM, Slava Krutelyov notifications@github.com wrote:

another (less) broken IB, sigh.

—
Reply to this email directly or view it on GitHub.

[ishvetso]

This branch contains modules to run isolation sums for electrons and photons: with map based veto and cone based veto, all these types of isolations can done for done for PUPPI-based isolation.

Modules can run either on miniAOD or AOD: for miniAOD one can use PUPPI weights that are stored in the packedCandidate directly by using CITKPFIsolationSumProducerForPUPPI with empty string for puppiValueMap. One can also rerun PUPPI and use PUPPI collection as input: for cone-based veto one should specify name of PUPPI collection and can use CITKPFIsolationSumProducer, for map-based veto one should specify the name of PUPPI value map (which is the same name as the name of PUPPI collection) but the name of collection should be either packedPFCandidates or pfNoPileupCanidates depending whether one runs on miniAOD or AOD (this is also illustrated in example in python/). For CITK twiki please refer here:

https://twiki.cern.ch/twiki/bin/viewauth/CMS/CommonIDAndIsolationFW

Studies have been for PUPPI-based isolation have been presented here:

https://indico.cern.ch/event/494563/contribution/2/attachments/1225182/1793161/iPUPPI_photons_EGM_9February.pdf

https://indico.cern.ch/event/482699/contribution/2/attachments/1215812/1775490/Shvetsov_update_iPUPPI_electrons.pdf

Electron cone based veto is not touched in this PR: I will create another PR to update as it does follow pfIsolationVariables 100%.