EMTF DQM Module

[swang373]

EMTF DQM Module

• L1TStage2EMTF.h
• L1TStage2EMTF.cc
• L1TStage2EMTF_cfi.py

This module was written following the naming convention set forth by Jing Yu and Esmaeel and currently monitors basic hardware values stored in the EMTFOutputCollection.

EMTF Unpacker

emtfStage2Digis_cfi.py
EMTFOutput.h

The file EMTFOutput.h was modified with permission from Andrew to fix some method declarations. The python configuration file was provided by Andrew, with some naming changes to follow convention.

Testing

This module was compiled and tested within CMSSW_8_0_0_pre6. The input files used were the following from MWGR2:

• 'root://eoscms//store/express/Commissioning2016/ExpressCosmics/FEVT/Express-v1/000/264/593/00000/E8F68B40-0ED2-E511-90DB-02163E0145B3.root'
• 'root://eoscms//store/express/Commissioning2016/ExpressCosmics/FEVT/Express-v1/000/264/593/00000/EA333C9D-2BD2-E511-AF4D-02163E0138BE.root'
• 'root://eoscms//store/express/Commissioning2016/ExpressCosmics/FEVT/Express-v1/000/264/593/00000/EC0A64B5-21D2-E511-B525-02163E0136D0.root'
• 'root://eoscms//store/express/Commissioning2016/ExpressCosmics/FEVT/Express-v1/000/264/593/00000/EC871D40-1AD2-E511-96AF-02163E0133C2.root'

[cmsbuild]

A new Pull Request was created by @swang373 (Sean-Jiun Wang) for CMSSW_8_0_X.

It involves the following packages:

DQM/L1TMonitor
DataFormats/L1TMuon
EventFilter/L1TRawToDigi

The following packages do not have a category, yet:

DataFormats/L1TMuon

@cmsbuild, @vanbesien, @mulhearn, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[mulhearn]

I'm OK with this, but note I haven't turned on EMTF unpacking in L1T standard sequences yet. Indeed, I'd like to leave this out of MWGR until we have exercised the L1T+HLT without any glitches, and have solid integration test with RAW data file that includes all of Stage-2 L1T. Of course, we can have special version of sequence for online DQM... just talking about what goes in release.

[mulhearn]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11607/console

[cmsbuild]

+1
Tested at: 27c069c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13513/11607/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13513/11607/summary.html

[deguio]

please submit to 81x as well.

[deguio]

ciao swang373,
I am reviewing the code right now. how are we supposed to run this code? do you plan to include the modules from the stage2 config at:
https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py

or do provide an additional cfg? including esmaeel in this thread.

please let us know asap, cause at the moment we cannot proceed (unless I am missing something).

@EsmaeelEskandari @jingyucms

[swang373]

Ciao Federico,

You are correct, I had not modified the necessary configuration files in DQM/L1TMonitor. Sorry about that.

In https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/DQM/L1TMonitor/python/L1TStage2_cff.py:
The following imports are necessary

from DQM.L1TMonitor.L1TStage2EMTF_cfi import *
from EventFilter.L1TRawToDigi.emtfStage2Digis_cfi import *

and l1tStage2Emtf needs to be added to the l1tStage2online sequence.

Then the emtfStage2Digis need to be added in the main configuration file on line 55: https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py#L55

This was enough for me to test the code locally with an l1tstage2_cfg file Esmaeel provided me.

[deguio]

ok. could you add a commit to this very same PR with the needed changes?
once done please don't forget to submit the same PR to 81x as well.
thanks,
F.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13513/11711/summary.html

[deguio]

@swang373
please let me know which is the correspondent PR for 81x.
if you want to test, just choose a recent IB.
thanks,
F.

[swang373]

@deguio
The correspondent PR for 81X is #13630.

[deguio]

+1

[mulhearn]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[deguio]

@swang373
why this PR was closed? please re-open asap if you want it to be merged.
thanks,
F.

[swang373]

@deguio

Sorry about that!

[deguio]

no problem.
F.

[davidlange6]

what are the plans for also adding this unpacker to the tier-0? @mulhearn