New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added customizations to run pp reco on peripheral HI events #13603
Added customizations to run pp reco on peripheral HI events #13603
Conversation
A new Pull Request was created by @mandrenguyen for CMSSW_8_1_X. It involves the following packages: RecoHI/Configuration @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@mandrenguyen |
Pull request #13603 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
Thanks for the suggestion @slava77 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
process.tobTecStepSeedsTripl.OrderedHitsFactoryPSet.GeneratorPSet.maxElement = cms.uint32(1000000) | ||
process.tobTecStepSeedsPair.OrderedHitsFactoryPSet.maxElement = cms.uint32(1000000) | ||
process.pixelPairStepSeeds.OrderedHitsFactoryPSet.maxElement = cms.uint32(1000000) | ||
process.jetCoreRegionalStepSeeds.OrderedHitsFactoryPSet.maxElement = cms.uint32(1000000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not repeat the same literal strings or integers. Set a string variable equal to "strip < 400000 && pixel < 40000 && (strip < 60000 + 7.0*pixel) && (pixel < 8000 + 0.14*strip)"
and then use it to set the parameters. Similarly, set a well-named integer variable to 1000000, and then use it to set the maxElement
parameters.
Pull request #13603 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
Pull request #13603 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
+1
Note that DQM sequence can be added as well with changes from #13688 included. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Added customizations to run pp reco on peripheral HI events
Changes the limits of number of clusters for the pp tracking and adds an option to store calo towers.
75X PR will follow, for reprocessing PbPb datasets in the same release used for data taking.