Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customizations to run pp reco on peripheral HI events #13603

Merged
merged 4 commits into from Mar 12, 2016

Conversation

mandrenguyen
Copy link
Contributor

Changes the limits of number of clusters for the pp tracking and adds an option to store calo towers.
75X PR will follow, for reprocessing PbPb datasets in the same release used for data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

A new Pull Request was created by @mandrenguyen for CMSSW_8_1_X.

It involves the following packages:

RecoHI/Configuration

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @richard-cms, @echapon, @yenjie, @kurtejung, @istaslis, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 4, 2016

@mandrenguyen
now with 4 functions in RecoHI/Configuration/python/customise_PPwithHI.py
I think a default combined customization function should be introduced (can even be def customise:)
I don't find it practical to put all 4 in the --customise arguments.
That's unless you actually want to mix and match.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

Pull request #13603 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@mandrenguyen
Copy link
Contributor Author

Thanks for the suggestion @slava77
Now the customize is called from a single line and I merged the data and MC cases with if statements

@slava77
Copy link
Contributor

slava77 commented Mar 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11759/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

process.tobTecStepSeedsTripl.OrderedHitsFactoryPSet.GeneratorPSet.maxElement = cms.uint32(1000000)
process.tobTecStepSeedsPair.OrderedHitsFactoryPSet.maxElement = cms.uint32(1000000)
process.pixelPairStepSeeds.OrderedHitsFactoryPSet.maxElement = cms.uint32(1000000)
process.jetCoreRegionalStepSeeds.OrderedHitsFactoryPSet.maxElement = cms.uint32(1000000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not repeat the same literal strings or integers. Set a string variable equal to "strip < 400000 && pixel < 40000 && (strip < 60000 + 7.0*pixel) && (pixel < 8000 + 0.14*strip)" and then use it to set the parameters. Similarly, set a well-named integer variable to 1000000, and then use it to set the maxElement parameters.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

Pull request #13603 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

@cmsbuild
Copy link
Contributor

Pull request #13603 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2016

+1

for #13603 e733721

  • code changes are the same as in Added customizations to run pp reco on peripheral HI events #13604 ; to provide a customization to be applied to pp scenario to be able to run on HI data inputs
  • jenkins tests pass (no actual runtime tests are done by jenkins for the proposed change)
  • tested locally in CMSSW_8_1_0_pre1 using 100 events each from HIHardProbes (262694 LS 190) and HIHardProbesPeripheral (262768 LS 378) running 8 threads
    The command was
cmsDriver.py step3  --conditions auto:run2_data_relval -s \ RAW2DIGI,L1Reco,RECO,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias+EcalESAlign \
--runUnscheduled  --process RECO --data  --eventcontent RECO,AOD,MINIAOD --scenario pp\
 --datatier RECO,AOD,MINIAOD --era Run2_50ns,Run2_HI --customise\
 RecoHI/Configuration/customise_PPwithHI.customisePPwithHI -n 100 --filein file:a.root \
 --nThreads=8 --repacked

-  HIHardProbes events fail track seeding in ~50% of events
- HIHardProbesPeripheral didn't have any errors related to too many clusters
    - caloTowers show up in AOD and take about 10% of the event size.

Note that DQM sequence can be added as well with changes from #13688 included.
Without it the mass replace of input tags done in --repacked doesn't work.

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11849/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Mar 12, 2016
Added customizations to run pp reco on peripheral HI events
@davidlange6 davidlange6 merged commit 08fb7f0 into cms-sw:CMSSW_8_1_X Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants