Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customizations to run pp reco on peripheral HI events #13604

Merged
merged 4 commits into from Mar 30, 2016

Conversation

mandrenguyen
Copy link
Contributor

Same as #13603
Modifies number of cluster limits in tracking and allows us to store calotowers.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

A new Pull Request was created by @mandrenguyen for CMSSW_7_5_X.

It involves the following packages:

RecoHI/Configuration

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @richard-cms, @echapon, @yenjie, @kurtejung, @istaslis, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11760/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 8, 2016

@mandrenguyen: When is a new 75X release with this PR needed?

@mandrenguyen
Copy link
Contributor Author

Hi @cvuosalo
Within a couple of weeks would be nice.

@slava77
Copy link
Contributor

slava77 commented Mar 9, 2016

@mandrenguyen
what kind of PbPb data do you expect this to run on?
Would it go all the way to HIHardProbes (IIRC, the more complex events are in it) ?

@mandrenguyen
Copy link
Contributor Author

@slava77 Yes, but it will be run on the peripheral event triggers.
Large scale tests have already been done for the 30-100% most central events, which show that the memory consumption is reasonable.

@slava77
Copy link
Contributor

slava77 commented Mar 9, 2016

@mandrenguyen
are these triggers selected separately or is there a filter that will need to be passed to the cmsDriver as well?

Will the reprocessing that you consider be done with central workflow submission machinery, or is this purely for (super)user level reprocessing at HI T2?

@mandrenguyen
Copy link
Contributor Author

@slava77 Yeah, we'll have to filter on the trigger paths in the cfg. I believe this will be done with the central workflow machinery, but using the Vanderbilt HI T2

@slava77
Copy link
Contributor

slava77 commented Mar 9, 2016

IIRC, the central workflow machinery needs cmsDriver command.

@slava77
Copy link
Contributor

slava77 commented Mar 10, 2016

@mandrenguyen
Is it going to be once in a lifetime processing case or do you plan to do something regularly?
For continuing support this setup likely needs a relval matrix setup.
It doesn't have to be in this PR, I'm just using this thread to understand initial goal.

I'd like to ask for a presentation in the next RECO meeting (will do more officially by email)

@mandrenguyen
Copy link
Contributor Author

@slava77 Wei Li (current HI convener) is managing this. I think he was going to make the request at PPD, but if you think it's more appropriate, I can advise him to present at RECO.

@slava77
Copy link
Contributor

slava77 commented Mar 10, 2016

On 3/10/16 6:02 AM, mandrenguyen wrote:

@slava77 https://github.com/slava77 Wei Li (current HI convener) is
managing this. I think he was going to make the request at PPD, but if
you think it's more appropriate, I can advise him to present at RECO.

I think that both PPD and RECO will need to be aware of what goes in,
more so in case if you would like a regular relval setup.
pp with HI inputs looks like a pretty good candidate to be checked
regularly,
if this kind of reprocessing will happen again.


Reply to this email directly or view it on GitHub
#13604 (comment).

@slava77
Copy link
Contributor

slava77 commented Mar 11, 2016

@mandrenguyen
please clarify the logic to change the cuts in modifyClusterLimits method.
Specifically

  • why was jetCoreRegionalStepSeeds ClusterCheckPSet.cut left unchanged. Is this intentional?
  • somewhat technical at this point -- you also include modifications to the following modules that are not running in pp (more may be better, but if we cleanup the loaded modules in 81X, the customisations will fail since the don't check for existence of these modules):
    globalSeedsFromTriplets 
    globalMixedSeeds    
    globalPixelLessSeeds
    globalPixelSeeds
    globalSeedsFromPairsWithVertices
    regionalCosmicTrackerSeeds
    photonConvTrajSeedFromQuadruplets

@cmsbuild
Copy link
Contributor

Pull request #13604 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Mar 11, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11846/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2016

+1

for #13604 3dd7bfe

  • code changes are in line with what needs to be done to get tracking to run on moderately complex HI inputs
  • jenkins tests pass (they don't really test much)
  • tested locally with HIHardProbes (262694 LS 190) and HIHardProbesPeripheral (262768 LS 378) from 2015 with a setup derived from 50ns relval processing, including extras that will not be used in HI reprocessing
cmsDriver.py step3  --conditions auto:run2_data_25ns14e33_v4\
 -s RAW2DIGI,L1Reco,RECO,EI,PAT,ALCA:SiStripCalZeroBias+SiStripCalMinBias+TkAlMinBias\
 --runUnscheduled  --process reRECO --data  --eventcontent RECO,AOD,MINIAOD --scenario pp\
 --datatier RECO,AOD,MINIAOD --customise \
Configuration/DataProcessing/RecoTLR.customiseDataRun2Common,\
SLHCUpgradeSimulations/Configuration/postLS1Customs.customise_New_HCAL,\
RecoHI/Configuration/customise_PPwithHI.customisePPwithHI\
 -n 100 --filein file:a.root --repacked 
- HIHardProbes events fail track seeding in ~50% of events
- HIHardProbesPeripheral didn't have any errors related to too many clusters

The events to be used in HI reprocessing are apparently even less dense than the inclusive HIHardProbesPeripheral

  • caloTowers show up in the AOD event content and add about 10% to the file size.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2016

BTW, the previous commit did not have the jetCore seed limits updated: about 10% of events were over the limit in HIHardProbesPeripheral; after the update they all passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants