Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare 'seedOnlyFromAbove_' as 'int'. #13643

Conversation

ghellwig
Copy link

@ghellwig ghellwig commented Mar 8, 2016

This member variable of the AlignmentTrackSelector was wrongly declared as
boolean, causing the gcc 5.3.0 to complain about a comparison which can never be
true.

Fixes issue #13578

This member variable of the AlignmentTrackSelector was wrongly declared as
boolean, causing the gcc 5.3.0 to complain about a comparison which can never be
true.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_1_X.

It involves the following packages:

Alignment/CommonAlignmentProducer

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @pakhotin, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Mar 8, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11777/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

@mmusich
Copy link
Contributor

mmusich commented Mar 9, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 9, 2016
…omAbove_81X

Declare 'seedOnlyFromAbove_' as 'int'.
@cmsbuild cmsbuild merged commit 4ffd12d into cms-sw:CMSSW_8_1_X Mar 9, 2016
@ghellwig ghellwig deleted the fix-gcc530-warning_seedOnlyFromAbove_81X branch March 11, 2016 10:23
davidlange6 added a commit that referenced this pull request Mar 17, 2016
…omAbove_80X

Declare 'seedOnlyFromAbove_' as 'int' (Backport of #13643).
cmsbuild added a commit that referenced this pull request May 17, 2016
…omAbove_76X

Declare 'seedOnlyFromAbove_' as 'int' (Backport of #13643).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants