delete loaded cleanPatJets after the temporary load if it was not around already #13681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_1_X. It involves the following packages: PhysicsTools/PatUtils @cmsbuild, @vadler, @davidlange6, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
davidlange6
added a commit
that referenced
this pull request
Mar 12, 2016
…ATCutParser-temp-cleanPatJets delete loaded cleanPatJets after the temporary load if it was not around already
davidlange6
added a commit
that referenced
this pull request
Mar 17, 2016
…ATCutParser-temp-cleanPatJets delete loaded cleanPatJets after the temporary load if it was not around already (same as #13681 )
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a technical side, this cleans up the temporary module loaded to the process only for the purpose of cloning it.
On a practical side, this also recovers back 500MB of extra memory triggered by PATStringCutObjectSelector due to jetCleaning loaded in #13372 / #13115 .
The default cleaner has a non-trivial cleaning selector in tkIsoElectrons and is never used in miniAOD workflow, while the derived cleaners loaded by jetCleaning have trivial selectors only (which do not use much memory).
[it looks like there are enough different context line that this PR is independent from #13372 / #13115 . ]
A better solution for PATStringCutObjectSelector memory use will need a more targeted instantiation selector functions (instead of all possible pat objects).