Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAT btag update (80X) #13686

Merged

Conversation

ferencek
Copy link
Contributor

A follow-up to #13098 that synchronizes PAT with the recent cleanup of old b-taggers. No changes to RECO but it affects MiniAOD by updating the list of default b-taggers stored with slimmed jets.

This is a 80X backport of #13685 and if possible, would like to include it in the 80X MiniAOD production together with #13605.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_8_0_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/MuonAlignment
CalibTracker/SiStripESProducers
Calibration/EcalAlCaRecoProducers
Calibration/HcalIsolatedTrackReco
CommonTools/PileupAlgos
CommonTools/RecoAlgos
CommonTools/Utils
CondCore/CondDB
CondFormats/DataRecord
CondFormats/MFObjects
CondFormats/SiStripObjects
CondTools/SiPixel
Configuration/Applications
Configuration/StandardSequences
DQM/BeamMonitor
DQM/DTMonitorModule
DQM/EcalMonitorClient
DQM/EcalMonitorTasks
DQM/Integration
DQM/L1TMonitor
DQM/RCTMonitor
DQM/SiStripCommissioningSources
DQM/SiStripMonitorClient
DQM/SiStripMonitorTrack
DQMOffline/Configuration
DQMOffline/Hcal
DQMOffline/JetMET
DQMServices/Components
DQMServices/Core
DQMServices/Diagnostic
DataFormats/BTauReco
DataFormats/HcalIsolatedTrack
DataFormats/L1TMuon
DataFormats/Math
DataFormats/MuonSeed
DataFormats/PatCandidates
DataFormats/Provenance
DataFormats/SiStripCluster
DataFormats/SiStripCommon
DataFormats/SiStripDetId
DataFormats/TrackReco
DetectorDescription/RegressionTest
Documentation/ReferenceManualScripts
ElectroWeakAnalysis/Utilities
ElectroWeakAnalysis/ZMuMu
EventFilter/EcalRawToDigi
EventFilter/L1TRawToDigi
FWCore/Framework
FWCore/Integration
FWCore/MessageLogger
FWCore/Modules
FWCore/ParameterSet
FWCore/Utilities
FastSimulation/Calorimetry
FastSimulation/Configuration
FastSimulation/HighLevelTrigger
FastSimulation/MaterialEffects
FastSimulation/Muons
FastSimulation/TrackerSetup
FastSimulation/Tracking
Fireworks/Geometry
Fireworks/ParticleFlow
GeneratorInterface/Configuration
GeneratorInterface/Core
GeneratorInterface/GenFilters
GeneratorInterface/LHEInterface
GeneratorInterface/PartonShowerVeto
GeneratorInterface/Pythia8Interface
Geometry/CMSCommonData
Geometry/ForwardGeometry
Geometry/HGCalCommonData
Geometry/HcalCommonData
Geometry/TrackerCommonData
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder
HLTrigger/Configuration
HLTrigger/Egamma
HLTrigger/HLTanalyzers
HLTrigger/HLTfilters
HLTrigger/JetMET
HLTrigger/Muon
HLTrigger/special
HeavyFlavorAnalysis/Onia2MuMu
HeavyFlavorAnalysis/Skimming
IOMC/RandomEngine
IOPool/Output
IOPool/Streamer
JetMETCorrections/Modules
JetMETCorrections/Type1MET
L1Trigger/Configuration
L1Trigger/GlobalCaloTrigger
L1Trigger/L1TGlobal

@diguida, @lveldere, @cmsdoxy, @cerminar, @Martin-Grunewald, @covarell, @bendavid, @vanbesien, @govoni, @perrotta, @civanch, @cmsbuild, @fwyzard, @davidlange6, @vciulli, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @ianna, @deguio, @slava77, @ggovi, @vadler, @mmusich, @mulhearn, @ssekmen, @thuer, @monttj, @alja, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @abbiendi, @TaiSakuma, @argiro, @Martin-Grunewald, @tlampen, @ahinzmann, @threus, @geoff-smith, @venturia, @pakhotin, @mmarionncern, @battibass, @makortel, @acaudron, @jhgoh, @jdolen, @jlagram, @agrohsje, @ferencek, @cerati, @trocino, @rociovilar, @barvic, @wmtan, @GiacomoSguazzoni, @tocheng, @VinInn, @nhanvtran, @rovere, @jalimena, @schoef, @mschrode, @mmusich, @dgulhan, @mkirsano, @apfeiffer1, @batinkov, @imarches, @gbenelli, @wddgit, @alja, @dkotlins, @gpetruc, @matt-komm, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

An extended test of workflow 25202.0_TTbar_13 with 70 events against baseline CMSSW_8_0_2 shows no significant differences. There is no change in RECO event content. Mini-AOD event content shows very small increases in patJets collections:

-----------------------------------------------------------------
   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
   1531.6 ->      1538.2          7      0.4   0.01     patJets_slimmedJetsAK8__RECO.
   3515.6 ->      3545.6         30      0.9   0.04     patJets_slimmedJets__RECO.
   2561.5 ->      2577.5         16      0.6   0.02     patJets_slimmedJetsPuppi__RECO.
-------------------------------------------------------------
    79862 ->       79914         53             0.1     ALL BRANCHES

@cmsbuild
Copy link
Contributor

Pull request #13686 was updated. @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please check and sign again.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11847/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13686 1c63730

Small b-tag update for patJets.

#13685 is the 81X version of this PR.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-03-08-2300 show no significant differences, as expected. As discussed above, patJets collections in Mini-AOD increase in size very slightly, but RECO event content is unchanged.

@cvuosalo cvuosalo mentioned this pull request Mar 14, 2016
davidlange6 added a commit that referenced this pull request Mar 17, 2016
@davidlange6 davidlange6 merged commit 5b42169 into cms-sw:CMSSW_8_0_X Mar 17, 2016
@ferencek ferencek deleted the PATbtagUpdate_from-CMSSW_8_0_2 branch March 17, 2016 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants