New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmssw 81 x sherpa weights #13756
Cmssw 81 x sherpa weights #13756
Conversation
…which event is which in GenLumiInfoHeader
A new Pull Request was created by @thuer (Sebastian Thüer) for CMSSW_8_1_X. It involves the following packages: GeneratorInterface/SherpaInterface @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
any news on this pull request? |
@bendavid is the new way of storing in line with what you had in mind? |
yes, looks ok. @thuer I assume that there is also an appropriate name for the nominal weight stored as the first element in the weightNames? |
The names given by sherpa are used, the nominal one would be just "Weight" |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
@covarell is this needed for 8_0_X as well? |
Adding the possibility of additional weights (scale / pdf variation) for Sherpa 2.2. Sherpa stores the weighst in form of named weights which we do not do in CMSSW, so the relevant names are stored in GenLumiInfoHeader for further use.