Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmssw 81 x sherpa weights #13756

Merged
merged 2 commits into from Mar 22, 2016
Merged

Conversation

thuer
Copy link
Contributor

@thuer thuer commented Mar 17, 2016

Adding the possibility of additional weights (scale / pdf variation) for Sherpa 2.2. Sherpa stores the weighst in form of named weights which we do not do in CMSSW, so the relevant names are stored in GenLumiInfoHeader for further use.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thuer (Sebastian Thüer) for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/SherpaInterface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@thuer
Copy link
Contributor Author

thuer commented Mar 22, 2016

any news on this pull request?

@covarell
Copy link
Contributor

@bendavid is the new way of storing in line with what you had in mind?

@bendavid
Copy link
Contributor

yes, looks ok. @thuer I assume that there is also an appropriate name for the nominal weight stored as the first element in the weightNames?

@thuer
Copy link
Contributor Author

thuer commented Mar 22, 2016

The names given by sherpa are used, the nominal one would be just "Weight"

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12010/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 22, 2016
@cmsbuild cmsbuild merged commit b140ba2 into cms-sw:CMSSW_8_1_X Mar 22, 2016
@thuer
Copy link
Contributor Author

thuer commented Mar 23, 2016

@covarell is this needed for 8_0_X as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants