Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting 1x1 HF output LUTs #13803

Merged
merged 1 commit into from Mar 24, 2016

Conversation

akhukhun
Copy link
Contributor

Make 1x1 HF output LUTs 4:1 to keep the TP lsb same as for 3x2 (0.5 GeV).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @akhukhun for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/CaloTPG

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@abdoulline
Copy link

It's worth mentioning that this PR is a forward -porting of
#13704

@mmusich
Copy link
Contributor

mmusich commented Mar 23, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12014/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 9fd68b4
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 23-Mar-2016 10:49:53 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

4.22 step1

DAS Error

134.911 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13803/12014/summary.html

@davidlange6 davidlange6 merged commit 9bb7bfd into cms-sw:CMSSW_8_1_X Mar 24, 2016
@fwyzard
Copy link
Contributor

fwyzard commented Mar 29, 2016

The crash seems to affect all the 2010 data workflows, and only them:

  3 4.6 MinimumBias2010A
  5 140.52 RunHI2010
  6 144.6 MinimumBias2010A
  7 140.51 RunHI2010

(the other errors are unrelated to CMSSW)

@akhukhun
Copy link
Contributor Author

I will submit a fix. (I tried to make it flexible but all tests were run for nominal scenario. It's crashing for lsb=0.25)

@akhukhun akhukhun deleted the fix-1x1-tp-luts-81X branch February 22, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants