-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusting 1x1 HF output LUTs #13704
Adjusting 1x1 HF output LUTs #13704
Conversation
A new Pull Request was created by @akhukhun for CMSSW_8_0_X. It involves the following packages: CalibCalorimetry/CaloTPG @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
@akhukhun - could you summarize in more detail the change? |
For 3x2 TPs there should be no change. |
@akhukhun does this imply changes as well in the conditions? |
No change in the offline conditions will be needed. We will have the corresponding output LUTs added in the online LUTs. |
+1 |
From HCAL internal discussion: need it in both in 80X( this one) and 81X(will be submitted soon) to correctly simulate TPs... |
please test |
The tests are being triggered in jenkins. |
+1 |
@mulhearn |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Make 1x1 HF output LUTs 4:1 to keep the TP lsb same as for 3x2 (0.5 GeV).