Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting 1x1 HF output LUTs #13704

Merged
merged 2 commits into from
Apr 12, 2016
Merged

Conversation

akhukhun
Copy link
Contributor

Make 1x1 HF output LUTs 4:1 to keep the TP lsb same as for 3x2 (0.5 GeV).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @akhukhun for CMSSW_8_0_X.

It involves the following packages:

CalibCalorimetry/CaloTPG

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Mar 14, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11861/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@akhukhun - could you summarize in more detail the change?

@akhukhun
Copy link
Contributor Author

For 3x2 TPs there should be no change.
For 1x1 TPs, the LSB before the change is 1/8 GeV.
The commit changes the output (compression) LUTs from identity (1:1) to 4:1, resulting in 1x1 HF TP LSB = 0.5 GeV -- the same as for 3x2 TPs.

@mmusich
Copy link
Contributor

mmusich commented Mar 17, 2016

@akhukhun does this imply changes as well in the conditions?

@akhukhun
Copy link
Contributor Author

No change in the offline conditions will be needed. We will have the corresponding output LUTs added in the online LUTs.

@mmusich
Copy link
Contributor

mmusich commented Mar 17, 2016

+1

@abdoulline
Copy link

From HCAL internal discussion: need it in both in 80X( this one) and 81X(will be submitted soon) to correctly simulate TPs...

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

Pull request #13704 was updated. @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Apr 1, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12125/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

@mmusich
Copy link
Contributor

mmusich commented Apr 5, 2016

+1

@abdoulline
Copy link

@mulhearn
we need it for correct HCAL TPs emulation in 80X

@rekovic
Copy link
Contributor

rekovic commented Apr 6, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17ab3e9 into cms-sw:CMSSW_8_0_X Apr 12, 2016
@akhukhun akhukhun deleted the fix-1x1-tp-luts branch February 22, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants