Split up GEM and ME0 customizations #13963

dildick · 2016-04-06T14:59:12Z

As requested by @slava77 in #13880 (comment) this PR splits up the GEM and ME0 customizations. GEMs will be enabled starting Run3 (GE1/1), with (possibly) an extension in Phase2 (GE2/1). ME0 will only be enabled starting Phase2. Including GEMs in the Run2_2017 era may be done in the future if the GE1/1 slice test goes well.

This PR is purely technical
It introduces "Run3" and "Run3_GEM" in which GE1/1 customizations are applied
Phase2 and Phase2_dev include "Run3_GEM" and ME0 customizations
The baseline or other eras should not be affected.

HGCal and DT fail at the DIGI and L1 step respectively in the simulation unfortunately. However, the simple cmsDriver command below does produce a syntactically correct configuration (see #13880 (comment))

cmsDriver.py SingleMuPt100_cfi  \
--conditions auto:upgradePLS3 \
-n 10 \
--eventcontent FEVTDEBUGHLT \
-s GEN,SIM,DIGI:pdigi_valid,L1,DIGI2RAW,RAW2DIGI,L1Reco,RECO,VALIDATION \
--datatier GEN-SIM-RECO-RAW-VALIDATION \
--geometry Extended2023Muon,Extended2023MuonReco \
--era Phase2 \
--magField 38T_PostLS1 \
--no_exec \
--fileout file:out_all.root

@calabria, @jshlee

cmsbuild · 2016-04-06T14:59:31Z

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_8_1_X.

It involves the following packages:

Configuration/StandardSequences
IOMC/RandomEngine
RecoLocalMuon/Configuration
RecoMuon/Configuration
SimGeneral/MixingModule
SimGeneral/TrackingAnalysis
SimMuon/Configuration
SimMuon/MCTruth
Validation/Configuration
Validation/RecoMuon

@smuzaffar, @civanch, @Dr15Jones, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @battibass, @makortel, @wmtan, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @bellan, @wddgit, @jhgoh, @cerati, @trocino, @dgulhan, @bachtis, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-04-07T13:44:46Z

@cmsbuild please test

cmsbuild · 2016-04-07T13:45:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12229/console

cmsbuild · 2016-04-07T16:47:15Z

+1
Tested at: ff26a91
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13963/12229/summary.html

cmsbuild · 2016-04-07T17:50:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13963/12229/summary.html

mdhildreth · 2016-04-07T19:44:57Z

+1

Dr15Jones · 2016-04-11T19:33:55Z

IOMC/RandomEngine/python/IOMC_cff.py

    object.simMuonME0Digis = cms.PSet(
        initialSeed = cms.untracked.uint32(1234567),
        engineName = cms.untracked.string('HepJamesRandom')
    )

 from Configuration.StandardSequences.Eras import eras
+eras.run3_GEM.toModify( RandomNumberGeneratorService, func=_modifyRandomNumberGeneratorServiceForRun3 )


These can now be expressed more simply

eras.run3_GEM.toModify(RandomNumberGeneratorService, simMuonGEMDigis = dict( initialSeed = cms.untracked.uint32(1234567), engineName = cms.untracked.string('HepJamesRandom')) )

Dr15Jones · 2016-04-11T19:41:49Z

+1

cmsbuild · 2016-04-29T13:37:23Z

Pull request #13963 was updated. @smuzaffar, @civanch, @Dr15Jones, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @franzoni, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

dildick · 2016-04-29T13:37:28Z

Rebased onto CMSSW_8_1_X_2016-04-28-2300. I took out the phase1Pixel and trackingPhase1 from the Phase2 era to resolve merge conflicts https://github.com/cms-sw/cmssw/pull/14180/files#diff-9a04431149d3c6b0186fe8a0216a8463

kpedro88 · 2016-04-29T13:59:29Z

@cmsbuild please test

cmsbuild · 2016-04-29T13:59:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12722/console

Dr15Jones · 2016-04-29T14:10:20Z

+1

davidlange6 · 2016-04-29T14:16:28Z

RecoLocalMuon/Configuration/python/RecoLocalMuon_EventContent_cff.py

-eras.phase2_muon.toModify( RecoLocalMuonFEVT, func=_modifyRecoLocalMuonEventContentForPhase2 )
-eras.phase2_muon.toModify( RecoLocalMuonRECO, func=_modifyRecoLocalMuonEventContentForPhase2 )
-eras.phase2_muon.toModify( RecoLocalMuonAOD,  func=_modifyRecoLocalMuonEventContentForPhase2 )
+def _updateOutput( era, outputPSets, commands):


for the next PR... this should just get moved to normal cff that manage the event content. If the collections are not produced, they won't be part of the event content
@dildick

@davidlange6 Which file is that?

its in fact this same one.. RecoLocalMuon/Configuration/python/RecoLocalMuon_EventContent_cff.py - we hopefully can avoid era statements in the event content

On Apr 29, 2016, at 4:19 PM, Sven Dildick notifications@github.com wrote:

In RecoLocalMuon/Configuration/python/RecoLocalMuon_EventContent_cff.py:

from Configuration.StandardSequences.Eras import eras
-eras.phase2_muon.toModify( RecoLocalMuonFEVT, func=_modifyRecoLocalMuonEventContentForPhase2 )
-eras.phase2_muon.toModify( RecoLocalMuonRECO, func=_modifyRecoLocalMuonEventContentForPhase2 )
-eras.phase2_muon.toModify( RecoLocalMuonAOD, func=_modifyRecoLocalMuonEventContentForPhase2 )
+def _updateOutput( era, outputPSets, commands):

@davidlange6 Which file is that?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

cmsbuild · 2016-04-29T16:24:13Z

+1
Tested at: e41bb44
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13963/12722/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d702493
c25df27
6eb471a
2b57736
1d52eaa
bc2fbe4
20d2f64
7b9cd49
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13963/12722/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13963/12722/git-merge-result

cmsbuild · 2016-04-29T17:19:01Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13963/12722/summary.html

slava77 · 2016-04-29T18:00:56Z

+1

for #13963 e41bb44

rebased since last signoff to update Configuration/StandardSequences/python/Eras.py and resolve conflicts
- changes in the last version of this PR 5e996cd...99b424b can be compared to this one d702493...e41bb44, in case it is necessary
jenkins tests pass
- the comparisons are not descriptive in this test (CMSSW_8_1_X_2016-04-28-2300 is used and more PRs were merged together with this one to do the tests, most notably Use a quick union algorithm to speed up PFBlockAlgo (factor of 2-3x) #14138, which triggers changes wrt the baseline)

dildick · 2016-04-29T18:21:44Z

@slava77 Thanks for prompt response. @kpedro88 @davidlange6 Can we have this integrated soon? Thanks!

kpedro88 · 2016-04-29T18:26:30Z

@civanch @deguio please sign ASAP

dildick · 2016-04-30T14:55:22Z

@davidlange6 Thanks!

cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 6, 2016

cmsbuild added reconstruction-pending simulation-pending dqm-pending core-pending operations-pending pending-signatures tests-pending orp-pending comparison-pending labels Apr 6, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 7, 2016

cmsbuild added tests-approved and removed tests-started labels Apr 7, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 7, 2016

cmsbuild added simulation-approved and removed simulation-pending labels Apr 7, 2016

Dr15Jones reviewed Apr 11, 2016
View reviewed changes

cmsbuild added core-approved and removed core-pending comparison-available labels Apr 11, 2016

cmsbuild added reconstruction-pending core-pending tests-pending comparison-pending and removed tests-approved labels Apr 29, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 29, 2016

cmsbuild added core-approved and removed core-pending labels Apr 29, 2016

davidlange6 reviewed Apr 29, 2016
View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Apr 29, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 29, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 29, 2016

davidlange6 merged commit 32d7510 into cms-sw:CMSSW_8_1_X Apr 30, 2016

dildick deleted the split-up-GEM-ME0-customs branch April 30, 2016 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split up GEM and ME0 customizations #13963

Split up GEM and ME0 customizations #13963

dildick commented Apr 6, 2016 •

edited

cmsbuild commented Apr 6, 2016

slava77 commented Apr 7, 2016

cmsbuild commented Apr 7, 2016

cmsbuild commented Apr 7, 2016

cmsbuild commented Apr 7, 2016

mdhildreth commented Apr 7, 2016

Dr15Jones Apr 11, 2016

Dr15Jones commented Apr 11, 2016

cmsbuild commented Apr 29, 2016

dildick commented Apr 29, 2016 •

edited

kpedro88 commented Apr 29, 2016

cmsbuild commented Apr 29, 2016 •

edited

Dr15Jones commented Apr 29, 2016

davidlange6 Apr 29, 2016

dildick Apr 29, 2016

davidlange6 Apr 29, 2016

cmsbuild commented Apr 29, 2016

cmsbuild commented Apr 29, 2016

slava77 commented Apr 29, 2016

dildick commented Apr 29, 2016

kpedro88 commented Apr 29, 2016

dildick commented Apr 30, 2016

Split up GEM and ME0 customizations #13963

Split up GEM and ME0 customizations #13963

Conversation

dildick commented Apr 6, 2016 • edited

cmsbuild commented Apr 6, 2016

slava77 commented Apr 7, 2016

cmsbuild commented Apr 7, 2016

cmsbuild commented Apr 7, 2016

cmsbuild commented Apr 7, 2016

mdhildreth commented Apr 7, 2016

Dr15Jones Apr 11, 2016

Choose a reason for hiding this comment

Dr15Jones commented Apr 11, 2016

cmsbuild commented Apr 29, 2016

dildick commented Apr 29, 2016 • edited

kpedro88 commented Apr 29, 2016

cmsbuild commented Apr 29, 2016 • edited

Dr15Jones commented Apr 29, 2016

davidlange6 Apr 29, 2016

Choose a reason for hiding this comment

dildick Apr 29, 2016

Choose a reason for hiding this comment

davidlange6 Apr 29, 2016

Choose a reason for hiding this comment

cmsbuild commented Apr 29, 2016

cmsbuild commented Apr 29, 2016

slava77 commented Apr 29, 2016

dildick commented Apr 29, 2016

kpedro88 commented Apr 29, 2016

dildick commented Apr 30, 2016

dildick commented Apr 6, 2016 •

edited

dildick commented Apr 29, 2016 •

edited

cmsbuild commented Apr 29, 2016 •

edited