Split up GEM and ME0 customizations #13963
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,13 +28,11 @@ | |
| 'keep *_cscSegments_*_*', | ||
| 'keep *_rpcRecHits_*_*') | ||
| ) | ||
| from Configuration.StandardSequences.Eras import eras | ||
| def _updateOutput( era, outputPSets, commands): | ||
|
There was a problem hiding this comment. for the next PR... this should just get moved to normal cff that manage the event content. If the collections are not produced, they won't be part of the event content There was a problem hiding this comment. @davidlange6 Which file is that? There was a problem hiding this comment. its in fact this same one.. RecoLocalMuon/Configuration/python/RecoLocalMuon_EventContent_cff.py - we hopefully can avoid era statements in the event content
|
||
| for o in outputPSets: | ||
| era.toModify( o, outputCommands = o.outputCommands + commands ) | ||
|
|
||
| _outputs = [RecoLocalMuonFEVT, RecoLocalMuonRECO, RecoLocalMuonAOD] | ||
| _updateOutput( eras.run3_GEM, _outputs, ['keep *_gemRecHits_*_*'] ) | ||
| _updateOutput(eras.phase2_muon, _outputs, ['keep *_me0RecHits_*_*', 'keep *_me0Segments_*_*']) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,11 +37,15 @@ | |
| # DT, CSC and RPC together (correct sequence for the standard path) | ||
| muonlocalreco = cms.Sequence(dtlocalreco+csclocalreco+rpcRecHits) | ||
|
|
||
| from RecoLocalMuon.GEMRecHit.gemRecHits_cfi import * | ||
| from RecoLocalMuon.GEMRecHit.me0LocalReco_cff import * | ||
|
|
||
| _run3_muonlocalreco = muonlocalreco.copy() | ||
| _run3_muonlocalreco += gemRecHits | ||
|
|
||
| _phase2_muonlocalreco = _run3_muonlocalreco.copy() | ||
| _phase2_muonlocalreco += me0LocalReco | ||
|
|
||
| from Configuration.StandardSequences.Eras import eras | ||
| eras.run3_GEM.toReplaceWith( muonlocalreco , _run3_muonlocalreco ) | ||
| eras.phase2_muon.toReplaceWith( muonlocalreco , _phase2_muonlocalreco ) | ||
|
There was a problem hiding this comment. @Dr15Jones could it be that this line is interfering with from RecoMuon.MuonIdentification.me0MuonReco_cff import me0MuonReco _phase2_muonGlobalReco = muonGlobalReco.copy() _phase2_muonGlobalReco += me0MuonReco eras.phase2_muon.toReplaceWith( muonGlobalReco, _phase2_muonGlobalReco ) If so, what is the recommended way to fix it? There was a problem hiding this comment. I think it requires doing from RecoMuon.MuonIdentification.me0MuonReco_cff import *in order to guarantee that all modules being used by There was a problem hiding this comment. Ok, this is fixed. I will some local integration tests to be sure. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,11 +120,15 @@ | |
| ) | ||
| globalValidationTrackingOnly = cms.Sequence() | ||
|
|
||
| from Validation.Configuration.gemSimValid_cff import * | ||
| from Validation.Configuration.me0SimValid_cff import * | ||
|
|
||
| _run3_globalValidation = globalValidation.copy() | ||
| _run3_globalValidation += gemSimValid | ||
|
|
||
| _phase2_globalValidation = _run3_globalValidation.copy() | ||
| _phase2_globalValidation += me0SimValid | ||
|
|
||
| from Configuration.StandardSequences.Eras import eras | ||
| eras.run3_GEM.toReplaceWith( globalValidation, _run3_globalValidation ) | ||
| eras.phase2_muon.toReplaceWith( globalValidation, _phase2_globalValidation ) | ||
|
There was a problem hiding this comment. @Dr15Jones is this the most practical way of dealing with modifications of the same thing by a "sequence" of modifiers? There was a problem hiding this comment. The order is guaranteed. There was a problem hiding this comment. For clarification (and my education), in case both
right? (I'm mainly confused by @slava77's "phase2_muon is executed first") There was a problem hiding this comment. What is we had another from of def _run3_globalValidation(seq):
global gemSimValid
return seq+gemSimValid
def _phase2_globalValidation(seq):
global gemSimValid
seq = seq.copyAndExclude([gemSimValid])
return seq+ me0SimValid
eras.run3_GEM.toReplaceWith( globalValidation, transform=_run3_globalValidation )
eras.phase2_muon.toReplaceWith(globalValidation, transform=_phase2_globalValidation)There was a problem hiding this comment. @makortel The order is the other way around. @slava77 had This also means that if one ran There was a problem hiding this comment. @Dr15Jones Now I'm confused even more. Has the implementation of Here is my understanding of the (current) internals of the era system. The fact that It also looks to me that the intention is to have in
To me it looks like the configuration above would do what is expected. But maybe I've missed some detail. There was a problem hiding this comment. @makortel You are right and I am wrong. I was thinking about how There was a problem hiding this comment. However, I think my proposal about def _run3_globalValidation(seq):
global gemSimValid
return seq+gemSimValid
def _phase2_globalValidation(seq):
global me0SimValid
return seq+ me0SimValid
eras.run3_GEM.toReplaceWith( globalValidation, transform=_run3_globalValidation )
eras.phase2_muon.toReplaceWith(globalValidation, transform=_phase2_globalValidation)and the end result of both There was a problem hiding this comment. @Dr15Jones - that would be my preference in terms of simplicity, ease of use, and correct handling of multiple customizations. I'm curious, though, why this syntax for There was a problem hiding this comment. @kpedro88 good catch! I had forgotten about the other syntax for
would not actually change |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,15 +73,19 @@ | |
| electronPostValidationSequenceMiniAOD | ||
| ) | ||
|
|
||
| from Validation.MuonGEMHits.PostProcessor_cff import * | ||
| from Validation.MuonGEMDigis.PostProcessor_cff import * | ||
| from Validation.MuonGEMRecHits.PostProcessor_cff import * | ||
| from Validation.HGCalValidation.HGCalPostProcessor_cff import * | ||
|
|
||
| _run3_postValidation = postValidation.copy() | ||
| _run3_postValidation += MuonGEMHitsPostProcessors | ||
| _run3_postValidation += MuonGEMDigisPostProcessors | ||
| _run3_postValidation += MuonGEMRecHitsPostProcessors | ||
|
|
||
| _phase2_postValidation = _run3_postValidation.copy() | ||
| _phase2_postValidation += hgcalPostProcessor | ||
|
|
||
| from Configuration.StandardSequences.Eras import eras | ||
| eras.run3_GEM.toReplaceWith( postValidation, _run3_postValidation ) | ||
|
There was a problem hiding this comment. @kpedro88 - also for the future - none of this should be on the post validation sequence - as nothing here depends on hlt - it can be on the prevalidation sequence. There was a problem hiding this comment. @davidlange6 There was a problem hiding this comment. err- sorry - yes - never mind me. |
||
| eras.phase2_hgcal.toReplaceWith( postValidation, _phase2_postValidation ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that
simMuonGEMDigisdoes not already exist inRandomNumberGeneratorService. Becuase it does not exist you can't use a dictionary and instead must declare a new PSet