Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCL SiPixel Alignment: integration of quality checks on payload and DQM module #13983

Merged
merged 13 commits into from Apr 13, 2016

Conversation

cerminar
Copy link
Contributor

@cerminar cerminar commented Apr 7, 2016

This PR modifies only the PCL sequences for the alignment of the Pixel large structures.
It integrates the needed checks for the creation of the payload and the DQM module to monitor the movements of the alignables.

This is needed to start testing the new workflow in production environment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

A new Pull Request was created by @cerminar for CMSSW_8_1_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm

@cmsbuild, @mmusich, @franzoni, @cerminar, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Apr 7, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12237/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

<flags EDM_PLUGIN="1"/>

<use name="DQMServices/Core"/>
<use name="PhysicsTools/UtilAlgos"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cerminar - why is this needed? (I hope it is not)

@cmsbuild
Copy link
Contributor

Pull request #13983 was updated. @cmsbuild, @mmusich, @franzoni, @cerminar, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Apr 12, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12323/console

@mmusich
Copy link
Contributor

mmusich commented Apr 12, 2016

+1
provided jenkins agrees

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 04c2d1f into cms-sw:CMSSW_8_1_X Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants