Update of DQM combo PR for L1T, including updates from 81x #14021
Conversation
The configuration files were modified heavily to test the ability to run locally on lxplus, then the settings were reverted, keeping only those changes which were relevant to enable running the EMTF DQM module.
For integration into production DQM sequence
Checkout files in EventFilter/L1TRawToDigi from cms-l1t-offline branch l1t-muon-CMSSW_8_0_0_pre6, committing only changes related to EMTF.
Checkout files in EventFilter/L1TRawToDigi from abrinke1 branch EMTF_DQM_dev_800pre6, committing only changes related to EMTF.
Checkout files in DataFormats/L1TMuon from cms-l1t-offline branch l1t-muon-CMSSW_8_0_0_pre6, committing only changes related to EMTF.
Checkout files in DataFormats/L1TMuon from abrinke1 branch EMTF_DQM_dev_800pre6, committing only changes related to EMTF.
Conflicts: DataFormats/L1TMuon/interface/EMTFOutput.h EventFilter/L1TRawToDigi/python/emtfStage2Digis_cfi.py Merge in the EMTF DQM module's 80X pull request.
TPs start at 1!
HF and HCAL digis will be combined in L1CaloLayer1 unpacker in this: cms-sw#13723 This branch would then cause an error if we include HF digis as currently implemented.
Organized the structure of l1tstage2_dqm_sourceclient-live_cfg.py for clarity. the nLCTs plot checks the Quality of the SP.
Cherry picked from cms-sw#13725 Resolved Conflicts: DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py DQM/L1TMonitor/python/L1TStage2_cff.py DQM/L1TMonitor/src/SealModule.cc
Resolved Conflicts: DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py DQM/L1TMonitor/python/L1TStage2_cff.py
Resolved Conflicts: DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py Both added: DQM/L1TMonitor/interface/L1TStage2uGT.h DQM/L1TMonitor/python/L1TStage2_cff.py Both added: DQM/L1TMonitor/src/L1TStage2uGT.cc DQM/L1TMonitor/src/SealModule.cc
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
db-pending
tests-approved
labels
|
Pull request #14021 was updated. @cmsbuild, @rekovic, @deguio, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 |
This is intended to supercede #13763.
Now that PR #13767 it is only 60 files.
It also includes some updates from 81X after the corresponding tgs-v4 and DQM PRs which addressed problems with the IB. With these changes, L1Trigger, DataFormats/L1TMuon, and EventFilter/L1TRawToDigi are identical with CMSSW_8_1_0_pre2.