CTPPS: DQM for TOTEM RP #14034

jan-kaspar · 2016-04-12T11:35:46Z

The code will not compile as it depends on many features not yet integrated in CMSSW. I'm issuing the PR so as people can start looking at the code. Compilable code is available in the CTPPS repository:
https://github.com/CTPPS/ctpps-offline.

cmsbuild · 2016-04-12T11:37:01Z

A new Pull Request was created by @jan-kaspar for CMSSW_8_1_X.

It involves the following packages:

DQM/TotemRP

The following packages do not have a category, yet:

DQM/TotemRP

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-04-12T13:13:04Z

@jan-kaspar
if you will use similar code to monitor other Totem subdetectors, it may be useful to have one DQM/Totem package.

jan-kaspar · 2016-04-12T13:43:49Z

@slava77 Fine with me.

deguio · 2016-04-12T14:20:52Z

please test

cmsbuild · 2016-04-12T14:21:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12405/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12408/console

cmsbuild · 2016-04-15T14:38:04Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2016-04-15T14:38:36Z

-1

Tested at: c33cd87

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14034/12408/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/src/TotemRPDQMSource.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/src/CorrelationPlotsSelector.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQMServices/FileIO/plugins/DQMFileSaverOnline.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQMServices/FileIO/plugins/DQMFileSaverBase.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/src/TotemRPDQMSource.cc:10:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/interface/TotemRPDQMSource.h:24:62: fatal error: DataFormats/TotemRPReco/interface/TotemRPCluster.h: No such file or directory
compilation terminated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQMServices/FileIO/plugins/DQMFileSaverPB.cc 
Entering library rule at src/DQMServices/Examples/plugins
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/src/TotemRPDQMSource.cc:10:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/interface/TotemRPDQMSource.h:24:62: fatal error: DataFormats/TotemRPReco/interface/TotemRPCluster.h: No such file or directory

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

Entering library rule at src/DQM/TotemRP/plugins
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/src/TotemRPDQMSource.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/src/CorrelationPlotsSelector.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/plugins/SealModule.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/src/TotemRPDQMSource.cc:10:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/interface/TotemRPDQMSource.h:24:10: fatal error: 'DataFormats/TotemRPReco/interface/TotemRPCluster.h' file not found
#include "DataFormats/TotemRPReco/interface/TotemRPCluster.h"
         ^
1 error generated.
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/src/TotemRPDQMSource.cc:10:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-14-2300/src/DQM/TotemRP/interface/TotemRPDQMSource.h:24:10: fatal error: 'DataFormats/TotemRPReco/interface/TotemRPCluster.h' file not found

jan-kaspar · 2016-04-20T13:47:58Z

This PR depends yet on #14134.

Need DataFormats/CTPPSReco.

…module added.

cmsbuild · 2016-05-25T19:20:24Z

+1
Tested at: 8230275
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14034/13200/summary.html

cmsbuild · 2016-05-25T20:23:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14034/13200/summary.html

jan-kaspar · 2016-05-29T14:10:50Z

Can I do anything else for this PR?

dmitrijus · 2016-05-30T13:03:47Z

+1
sorry for slow accept

dmitrijus · 2016-05-30T13:05:33Z

cms-sw/cms-bot#694

cmsbuild · 2016-05-30T15:18:03Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-05-30T15:18:05Z

Pull request #14034 was updated. @davidlange6 can you please check and sign again.

davidlange6 · 2016-05-30T15:25:42Z

+1

davidlt · 2016-05-31T16:28:30Z

@jan-kaspar why does it need a dependency on QString (QT)? CMSSW contains QT 4.8 which EOL and there are no guarantees that will be compiling with future toolchain versions. It's basically a dead piece of software.

Looks like you are doing string operations/matching, why does it need a QT?

P.S. This did broke builds on AArch64.

davidlt · 2016-05-31T16:36:51Z

Also CorrelationPlotsSelector.cc needs more cleaning: printf, exit(1).

dmitrijus · 2016-05-31T16:41:46Z

Please make another PR to remove qt dependency, qstring shouldn't be hard to replace with boost::string, or preferably, just plain std::string.

printf/exit shouldn't be used at all. Both should be replaced with a single throw of cms::Exception.

jan-kaspar · 2016-06-01T08:23:15Z

The Qt dependency inherits from our TOTEM-only DQM where Qt is used for GUI and thus use of QtString was convenient.

I will submit a next PR in the next days.

davidlange6 · 2016-06-09T18:47:26Z

@jan-kaspar - what is the status of this update?

jan-kaspar · 2016-06-10T08:15:58Z

The Qt dependence, exit and printf are removed in a follow-up PR #14836.

CTPPS: DQM for TOTEM RP - backport of #14034

Initial import from CTPPS repository.

c33cd87

cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 12, 2016

cmsbuild added pending-signatures tests-pending orp-pending new-package-pending comparison-pending labels Apr 12, 2016

cmsbuild added tests-started tests-rejected comparison-notrun comparison-pending and removed tests-pending tests-started comparison-pending comparison-notrun labels Apr 12, 2016

cmsbuild added comparison-notrun and removed comparison-pending labels Apr 15, 2016

cmsbuild added comparison-pending and removed comparison-notrun labels Apr 15, 2016

jan-kaspar added 2 commits April 22, 2016 12:20

Merge branch 'CMSSW_8_1_X' of github.com:cms-sw/cmssw into ctpps_dqm

8b0ae71

Need DataFormats/CTPPSReco.

Update after merging DataFormats/CTPPSReco, TotemDAQTriggerDQMSource …

38babfe

…module added.

cmsbuild removed the tests-rejected label Apr 22, 2016

cmsbuild added tests-started and removed tests-pending labels May 25, 2016

cmsbuild added tests-approved and removed tests-started labels May 25, 2016

cmsbuild added comparison-available and removed comparison-pending labels May 25, 2016

cmsbuild added dqm-approved fully-signed and removed new-package-pending pending-signatures labels May 30, 2016

cmsbuild added orp-approved and removed orp-pending labels May 30, 2016

cmsbuild merged commit 40dfe44 into cms-sw:CMSSW_8_1_X May 30, 2016

grzanka mentioned this pull request May 31, 2016

CTPPS: DQM for TOTEM RP - backport of #14034 #14696

Merged

jan-kaspar deleted the ctpps_dqm branch June 1, 2016 17:49

cmsbuild added a commit that referenced this pull request Jun 20, 2016

Merge pull request #14696 from CTPPS/ctpps_dqm_backport

bef50b5

CTPPS: DQM for TOTEM RP - backport of #14034

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTPPS: DQM for TOTEM RP #14034

CTPPS: DQM for TOTEM RP #14034

jan-kaspar commented Apr 12, 2016

cmsbuild commented Apr 12, 2016

slava77 commented Apr 12, 2016

jan-kaspar commented Apr 12, 2016

deguio commented Apr 12, 2016

cmsbuild commented Apr 12, 2016 •

edited by smuzaffar

cmsbuild commented Apr 15, 2016

cmsbuild commented Apr 15, 2016 •

edited by smuzaffar

jan-kaspar commented Apr 20, 2016

cmsbuild commented May 25, 2016

cmsbuild commented May 25, 2016

jan-kaspar commented May 29, 2016

dmitrijus commented May 30, 2016

dmitrijus commented May 30, 2016

cmsbuild commented May 30, 2016

cmsbuild commented May 30, 2016

davidlange6 commented May 30, 2016

davidlt commented May 31, 2016

davidlt commented May 31, 2016

dmitrijus commented May 31, 2016

jan-kaspar commented Jun 1, 2016

davidlange6 commented Jun 9, 2016

jan-kaspar commented Jun 10, 2016

CTPPS: DQM for TOTEM RP #14034

CTPPS: DQM for TOTEM RP #14034

Conversation

jan-kaspar commented Apr 12, 2016

cmsbuild commented Apr 12, 2016

slava77 commented Apr 12, 2016

jan-kaspar commented Apr 12, 2016

deguio commented Apr 12, 2016

cmsbuild commented Apr 12, 2016 • edited by smuzaffar

cmsbuild commented Apr 15, 2016

cmsbuild commented Apr 15, 2016 • edited by smuzaffar

jan-kaspar commented Apr 20, 2016

cmsbuild commented May 25, 2016

cmsbuild commented May 25, 2016

jan-kaspar commented May 29, 2016

dmitrijus commented May 30, 2016

dmitrijus commented May 30, 2016

cmsbuild commented May 30, 2016

cmsbuild commented May 30, 2016

davidlange6 commented May 30, 2016

davidlt commented May 31, 2016

davidlt commented May 31, 2016

dmitrijus commented May 31, 2016

jan-kaspar commented Jun 1, 2016

davidlange6 commented Jun 9, 2016

jan-kaspar commented Jun 10, 2016

cmsbuild commented Apr 12, 2016 •

edited by smuzaffar

cmsbuild commented Apr 15, 2016 •

edited by smuzaffar