Reinitializing deleted pointers to nullptr

[avetisya]

This is a small fix that sets deleted pointers to nullptr as requested in #14031 .

[cmsbuild]

A new Pull Request was created by @avetisya (Aram Avetisyan) for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/JSONMonitoring

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[Martin-Grunewald]

please test
PR for 80X?

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12368/console

[cmsbuild]

+1
Tested at: 96f6006
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14067/12368/summary.html

[avetisya]

PR for 80X?
I am trying, but I can't seem to make a pull request which has only this fix. What is the correct way to deal with a change that goes on top of something which has already been merged, but is not in an IB yet?

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[Martin-Grunewald]

Simply update the 80X PR you have already by pushing the additional fix to the same branch
you used to make the non-merged PR.

[fwyzard]

PR for 80X?

I am trying, but I can't seem to make a pull request which has only this fix. What is the correct way to deal with a change that goes on top of something which has already been merged, but is not in an IB yet?

Without trying myself, I think you could

• create an area for the latest IB
• git checkout CMSSW_8_0_X
• git pull
• git cherry-pick 96f6006 # this is the 8.1.x commit
• git push my-cmssw HEAD:nullptr-reinitialization-fix-80x

.A

[avetisya]

Thanks. I reused the old branch and it seems to work. I was worried that pushing to this branch would modify the existing pull requests which use it, but it looks like once they're merged, they can no longer be modified.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14067/12368/summary.html

[davidlange6]

+1