Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uMNio data skipping implemented #14170

Merged
merged 1 commit into from Apr 22, 2016
Merged

Conversation

Spudmeister
Copy link
Contributor

This pull request incorporates the same changes as my other one for CMSSW_8_1_X (#14158). In brief: This patch allows for HCAL to operate its laser during the global operations by preventing the special laser position information from being unpacked with the regular data.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Spudmeister for CMSSW_8_0_X.

It involves the following packages:

EventFilter/HcalRawToDigi

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 20, 2016

@cmsbuild please test

@Spudmeister @abdoulline
did I understand correctly that this mixed pin and HPD readout from the same FED is still in planning (no actual data was collected with it)? .. else we would have probably heard of failures

Do you know how these channels are handled on the DQM side (which runs in situ unpacking)?

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12527/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 20, 2016

+1

for #14170 9f195f4

  • HCAL unpacker to skip unpacking calibration laser PIN diode inputs coming in the same FED stream.
    ; the same commit ID as what's submitted to 81X
  • jenkins tests pass
  • only a subset of comparisons tests completed, but this is substantially the same as in 81X where all comparisons passed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@Spudmeister
Copy link
Contributor Author

@slava77 The readout of the data is possible, but disable because this patch was not in place. The unpacking of the data is currently being worked on for DQM to have access to it. That will be another pull request at some point.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 61c6aa2 into cms-sw:CMSSW_8_0_X Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants