Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Global Tag for Collisions2016_v1 L1T menu and splitting Ecal Pedestal tags #14281

Merged
merged 2 commits into from May 11, 2016

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 27, 2016

Summary of changes in Global Tags

RunII simulation

RunII data

@mmusich
Copy link
Contributor Author

mmusich commented Apr 27, 2016

plese test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @mmusich, @franzoni, @cerminar, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12684/console

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Apr 28, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12718/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Apr 29, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented May 3, 2016

@davidlange6 @mmusich
What is holding up this PR?

@Martin-Grunewald
Copy link
Contributor

@davidlange6
What is holding up integration of this PR?

@mmusich
Copy link
Contributor Author

mmusich commented May 4, 2016

@Martin-Grunewald, nothing is holding this on the alca side

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9de2535 into cms-sw:CMSSW_8_0_X May 11, 2016
@Martin-Grunewald
Copy link
Contributor

Hi @mmusich
Something must have gone wrong as there is now an error on an HIon real-data workflow:
(cf #14325 addOn test) using run2_hlt_hi:

----- Begin Fatal Exception 11-May-2016 21:37:51 CEST-----------------------
An exception of category 'InvalidInput' occurred while
   [0] Processing run: 263689 lumi: 5 event: 395501
   [1] Running path 'HLT_HIPuAK4CaloJet40_Eta5p1_v2'
   [2] Calling event method for module LXXXCorrectorProducer/'hltAK4CaloResidualCorrector'
Exception Message:
 cannot find key 8 in the JEC payload, this usually means you have to change the global tag
----- End Fatal Exception -------------------------------------------------

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented May 12, 2016

@mmusich
Hmm, I can't reproduce the jenkins test failure offline.... there all is fine!

@mmusich
Copy link
Contributor Author

mmusich commented May 12, 2016

@Martin-Grunewald let me have a look.

@mmusich
Copy link
Contributor Author

mmusich commented May 12, 2016

@Martin-Grunewald indeed everything looks fine:

$ conddb list 80X_dataRun2_HLTHI_frozen_v9 | grep AK4Calo
JetCorrectionsRecord         AK4CaloHLT     JetCorrectorParametersCollection_HI_PythiaCUETP8M1_5020GeV_753p1_AK4Calo_v4_hlt

$ conddb list JetCorrectorParametersCollection_HI_PythiaCUETP8M1_5020GeV_753p1_AK4Calo_v4_hlt
Since: Run   Insertion Time       Payload                                   Object Type                       
-----------  -------------------  ----------------------------------------  --------------------------------  
1            2016-03-07 17:26:34  d9f9a8bc9eb2f4c40aa1dee8d5c90aebe28c5d41  JetCorrectorParametersCollection  

$ conddb dump d9f9a8bc9eb2f4c40aa1dee8d5c90aebe28c5d41 | grep first
            <first>1</first>
            <first>2</first>
            <first>8</first>
            <first>10</first>

maybe the tests were trigger against an IB yet without the update?
How are we doing in 81X? We have the same Heavy Ion Data GT there. Is the HLT table the same as in #14325 ?

@Martin-Grunewald
Copy link
Contributor

Everywhere else it does work indeed!
So I guess you are right, the IB used for the jenkins test did not yet include the PR.
I asked for new tests (I thought once an IB is listed on the IB page it is used for the tests, but in this case there may have been a delay - maybe due to a specific architecture not ready).
So let's see what the new test brings.

@Martin-Grunewald
Copy link
Contributor

@mmusich
OK, all is fine with the tests redone! Thanks for your checking and apologies for the noise.

@mmusich mmusich deleted the update_HLT_GTs_80X branch April 22, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants