Fixes to L1T for simultaneous packing of Gt Inputs and Calo/GMT Outputs #14291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mulhearn for CMSSW_8_0_X. It involves the following packages: EventFilter/L1TRawToDigi @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@mulhearn - this has merge conflicts now - could you rebase? |
|
Yep! |
|
Made obsolete by #14323. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in the Stage2 unpacker for L1T made it impossible to pack GT inputs Calo/GMT outputs using the same code as designed. This led to crashes being untested until an early MW GR. The GT input unpacking was disabled.
This PR is the proper fix, which allows GT unpacker to be turned back on. This PR includes updates to our integration tests which check the unity of GT packing + unpacking. (As for Calo and GMT).