Updates to L1T packer needed to simultaneously pack GT inputs and GMT/Calo ouputs #14323
Conversation
|
A new Pull Request was created by @mulhearn for CMSSW_8_0_X. It involves the following packages: EventFilter/L1TRawToDigi @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
This PR passes internal L1T integration tests and bitwise reproduces L1T in CMSSW_806 (i.e. makes no change to L1T algorithms). |
|
+1 |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
The 81x version is under development. (Unfortunately this branch will not work as is in 81x) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 |
A bug in the Stage2 unpacker for L1T made it impossible to pack GT inputs Calo/GMT outputs using the same code as designed. This led to crashes being untested until an early MW GR. The GT input unpacking was disabled.
This PR is the proper fix, which allows GT unpacker to be turned back on. This PR includes updates to our integration tests which check the unity of GT packing + unpacking. (As for Calo and GMT).
This PR supersedes #14291.