Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added noexcept(false) to module destructors for gcc 6 #14396

Merged
merged 5 commits into from May 12, 2016

Commits on May 6, 2016

  1. Added noexcept(false) to module destructors for gcc 6

    For now, we will continue to allow module's destructors to throw exceptions. Explicitly added 'noexcept(false)' to base class destructors to silence warnings from gcc 6.
    Dr15Jones committed May 6, 2016
    Copy the full SHA
    83f2802 View commit details
    Browse the repository at this point in the history
  2. Added noexcept(false) to GenericBenchmark's destructor

    Because a module uses dual inheritance to GenericBenchmark and the base class for modules' use noexcept(false) we had to make GenericBenchmark's destructor just as loose.
    Dr15Jones committed May 6, 2016
    Copy the full SHA
    83a2087 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2016

  1. Removed unnecessary inheritance on TObject

    The EDProducer did not need to inherit from TObject and the inheritance was interfering with the change of the destructor to be noexcept(false).
    Dr15Jones committed May 9, 2016
    Copy the full SHA
    12a61cf View commit details
    Browse the repository at this point in the history

Commits on May 10, 2016

  1. Copy the full SHA
    b9f9a06 View commit details
    Browse the repository at this point in the history
  2. Explicitly allow destructor to throw exceptions

    This class is used as a base class for multiple inheritance with a
    framework module base class. For gcc 6 the framework modules explicitly
    declared that the destructors are allowed to thow exceptions [noexcept(false)].
    However, in the case of multiple inheritance, this meant all other base classes
    used also need to allow exceptions else there is a compile time error.
    Dr15Jones committed May 10, 2016
    Copy the full SHA
    1e89dbc View commit details
    Browse the repository at this point in the history