add track hit eff monitoring vs BX

[mtosi]

this PR is needed for monitoring the track hit efficiency vs BX
new plots will be created only when running TrackingDQMSourceTier0MinBias sequence
(which should be only on ZeroBias PD)

[mtosi]

@rovere @VinInn @deguio

[cmsbuild]

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_1_X.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorClient
DQM/TrackingMonitorSource

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[VinInn]

will this be backported in 80X and deployed in production?
any ETA?

[VinInn]

@cmsbuild , please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12869/console

[mtosi]

the idea is to have it in 80x as well
but I have to wait for its 81x integration, first
many PRs have been stacked recently :( ...

[dmitrijus]

+1
(assuming the tests are okay)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Pull request #14413 was updated. @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

[rovere]

I'm not quite sure the code is "correct". If you run both monitoring at the same time, i.e. _vsPU and _vsBX, you need to have a way to disentangle the two, which means you have to code the kind of monitoring you are doing in the KeyHasher, otherwise you are out of luck, in the sense that you'll have unnecessary collisions, which spoil the whole idea of hashing.

-1 (without any power .. ;) )

[cmsbuild]

+1
Tested at: cbd338f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14413/12869/summary.html

[dmitrijus]

Marco is right - please update KeyHasher ( https://github.com/mtosi/cmssw/blob/f7de06e42add53c2977e75941614a59738aaef91/DQM/TrackingMonitor/interface/TrackAnalyzer.h#L386 ) to include the k.monitoring.

I guess something trivial,such as return k.det*200 + k.subdet*2 + k.monitoring;

[cmsbuild]

Pull request #14413 was updated. @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14413/12869/summary.html

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12890/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 7b3e7d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14413/12890/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14413/12890/summary.html

[davidlange6]

+1

[mtosi]

I've just created PR #14448 for the back port in 80x
hope it is fine
thanks