Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeding of L2 muons: propagate L1 cands to ME2 if propagation to MB2 fails #14505

Merged
merged 2 commits into from May 18, 2016

Conversation

sarafiorendi
Copy link
Contributor

This PR is to fix the inefficiency due to failing propagation of L1 muons from the overlap
region to the reference frame (defined to be MB2 from L1).
The fix consists in a further tentative to propagate the L1 to the endcap reference frame
if the previous propagation fails.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sarafiorendi for CMSSW_8_1_X.

It involves the following packages:

RecoMuon/L2MuonSeedGenerator

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @bellan, @HuguesBrun, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 14, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12991/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 18, 2016

+1

for #14505 6565a2d

  • code changes are in line with description; only HLT is affected (not reco modules)
  • jenkins tests pass and comparisons show differences in HLT plots related to muons with an increase in efficiency
  • local tests with muon gun MC and doubleMu data show a significant increase of hltL2Muons and related efficiency in MC in the overlap region around 1.2; there is only very minor increase in the data test due to selection bias (HLT already required 2 muons in the original version)
    muon gun pt10 (similar for pt100)
    wf1320_hltl2muons_eff_v_eta

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 059e74d into cms-sw:CMSSW_8_1_X May 18, 2016
cmsbuild added a commit that referenced this pull request May 18, 2016
add tentative propagation to ME2 if MB2 fails (backport of #14505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants