Fix QIE11 unpacking bug

[kpedro88]

Further testing of #14461 revealed that only half (18 out of 36) of the CASTOR channels were being unpacked from RAW. The cause turned out to be an issue in the unpacker logic, only affecting QIE11 unpacking (which had not been used at all until now). This patch fixes the problem, and it will be added to #14462 for 80X.

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

EventFilter/HcalRawToDigi

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13122/console

[cmsbuild]

+1
Tested at: 40d94b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14599/13122/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14599/13122/summary.html

[kpedro88]

@slava77 please take a look

[slava77]

there are more than 10 PRs in reco queue.
Yours is about 10th in order.

[slava77]

+1

for #14599 40d94b9

• change is as described: earlier version had a bug for QIE11 with a half of digis captured by "else, for everything else, skip" due to a missing "else if"
• jenkins tests pass and comparisons with baseline show no difference
• local test in 273291 MET show expected behavior:
  • with the default emap there are now more entries in the HcalUnpackerReport corresponding to 18 more CRF channel digis
  • with the extended emap (see Monitor CASTOR table data (81X) #14461) the digis previously unpammed now show up as 36 digis in the QIE11DataFrameHcalDataFrameContainer_hcalDigis collection; other hcalDigis (QIE10, HcalCalibDataFrames sizes are unchanged)
    • ... for some reason from discussions in Monitor CASTOR table data (81X) #14461 I thought that CRF data should be also (or even only?) in HcalCalibDataFrames. I see that on the tested events the size of HcalCalibDataFrames collection is unchanged while the QIE11 size goes up. I guess it's a feature of the emap as well.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar