Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fake muon tracks become charged hadrons in PF #14669

Merged
merged 1 commit into from Sep 7, 2016

Conversation

bachtis
Copy link
Contributor

@bachtis bachtis commented May 27, 2016

This fixes tail events that appeared in 80X. Those fake tracks we have seen before but they were appearing in less pure iterations for which we applied Dpt/pt cuts

Actions taken:
+Add a very loose Dpt/pt cut <20 in other iterations
+Cut tracks that are not belonging to muons but are not high purity

THis should only affect events in tails

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bachtis (Michalis Bachtis) for CMSSW_8_0_X.

It involves the following packages:

RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @rafaellopesdesa, @cbernet this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 27, 2016

we need a PR in 81X.
This isn't going to go anywhere in 80X.
(at leas on t time scale of 3-6 months)

@slava77
Copy link
Contributor

slava77 commented May 27, 2016

[Aug 24: remove -1 ]
we can come back to this if some major reprocessing happens

cmsbuild added a commit that referenced this pull request Jun 5, 2016
Bugfix: Fake muon tracks become charged hadrons in PF  (81X version of #14669)
@davidlange6 davidlange6 closed this Jun 7, 2016
@davidlange6 davidlange6 reopened this Aug 24, 2016
@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14712/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 6c7a639

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14669/14712/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error

@cvuosalo
Copy link
Contributor

@cmsbuild please test
Try again after DAS error

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14717/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2016

+1

for #14669 6c7a639

I will still add a "hold", although this is just becoming a technical note.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2016

hold

to denote that this PR is to be merged only once a rereco release is to be made

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@davidlange6 davidlange6 merged commit 586601c into cms-sw:CMSSW_8_0_X Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants