New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Fake muon tracks become charged hadrons in PF #14669
Conversation
A new Pull Request was created by @bachtis (Michalis Bachtis) for CMSSW_8_0_X. It involves the following packages: RecoParticleFlow/PFProducer @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
we need a PR in 81X. |
[Aug 24: remove -1 ] |
Bugfix: Fake muon tracks become charged hadrons in PF (81X version of #14669)
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 6c7a639 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1
I will still add a "hold", although this is just becoming a technical note. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
hold to denote that this PR is to be merged only once a rereco release is to be made |
Pull request has been put on hold by @slava77 |
This fixes tail events that appeared in 80X. Those fake tracks we have seen before but they were appearing in less pure iterations for which we applied Dpt/pt cuts
Actions taken:
+Add a very loose Dpt/pt cut <20 in other iterations
+Cut tracks that are not belonging to muons but are not high purity
THis should only affect events in tails