Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fake muon tracks become charged hadrons in PF (81X version of #14669) #14670

Merged
merged 1 commit into from Jun 5, 2016

Conversation

bachtis
Copy link
Contributor

@bachtis bachtis commented May 27, 2016

This fixes tail events that appeared in 80X. Those fake tracks we have seen before but they were appearing in less pure iterations for which we applied Dpt/pt cuts

Actions taken:
+Add a very loose Dpt/pt cut <20 in other iterations
+Cut tracks that are not belonging to muons but are not high purity

THis should only affect events in tails

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bachtis (Michalis Bachtis) for CMSSW_8_1_X.

It involves the following packages:

RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @rafaellopesdesa, @cbernet this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 27, 2016

@bachtis please copy full description to this PR from 80X (edit the top section right below the title).
80X version is DOA by policy

@slava77
Copy link
Contributor

slava77 commented May 27, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13241/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@bachtis
Copy link
Contributor Author

bachtis commented Jun 1, 2016

Hello?

@slava77
Copy link
Contributor

slava77 commented Jun 1, 2016

it's not forgotten

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2016

Some related plots:
wf 1313 (3TeV dijet)
substantial decrease in pf ch around 1 TeV is balanced out by increase in pf nh (and also a bit in photons and muons)
all_sign720vsorig_qcd13tevpt3ts3t5wf1313p0c_log10recopfcandidates_particleflow__reco_obj_p17
all_sign720vsorig_qcd13tevpt3ts3t5wf1313p0c_log10recopfcandidates_particleflow__reco_obj_p57

ch MET tail is down substantially
all_sign720vsorig_qcd13tevpt3ts3t5wf1313p0c_log10recopfmets_pfchmet__reco_obj_pt
full pf MET is marginally affected
all_sign720vsorig_qcd13tevpt3ts3t5wf1313p0c_log10recopfmets_pfmet__reco_obj_pt
the chH fraction is down, as expected
all_sign720vsorig_qcd13tevpt3ts3t5wf1313p0c_recopfmets_pfmet__reco_obj_chargedhadronetfraction

yield of pfTaus at high pt end decreased by ~x2
[the ET is not fake here, unclear if it's all good; OTOH, it's unclear if the EI tau selection is still all that meaningful]
all_sign720vsorig_qcd13tevpt3ts3t5wf1313p0c_log10recopftaus_pftausei__reco_obj_pt
This looks like an effect for fakes.
I checked with Zptautau at M=4TeV
there is no significant effect:
all_sign720vsorig_testzpttm4tevc_log10recopftaus_pftausei__reco_obj_pt

Looking at jet components, the main migration is (chFrac1, photonFrac0) to some more sensible values (there are apparently sprays of pseudo-good tracks that were previously used up to turn all calo energy to charged hadrons)
wf1313_chfrac_dijet
wf1313_phfrac_dijet

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2016

+1

for #14670 6c7a639

  • code change is as described
  • jenkins tests pass and comparisons with baseline show small differences starting from PF
  • local tests with higher PT samples that are expected to be more affected show reasonable behavior (see plots posted above/earlier)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants