HCALDQM Updates upon the request from HCAL Operations/DPG #14743
Conversation
|
A new Pull Request was created by @vkhristenko (Viktor Khristenko) for CMSSW_8_1_X. It involves the following packages: DQM/HcalCommon @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
please test |
| { | ||
| edm::Handle<QIE10DigiCollection> cqie10; | ||
| if (!e.getByToken(_tokQIE10, cqie10)) | ||
| std::cout << "Collection isn't available" << std::endl; |
There was a problem hiding this comment.
Please replace with LogWarning, LogError or cms::Exception.
Use of std::cout is forbidden!
There was a problem hiding this comment.
@vkhristenko @dmitrijus - yes, this needs to be changed
|
80x reference: #14742 |
|
+1 This should be merged. It has been open for far too long. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
| @@ -215,6 +215,42 @@ namespace hcaldqm | |||
| int const RAW_EMPTY = 16; | |||
| int const UTCA_DATAFLAVOR = 0x5; | |||
|
|
|||
| double const adc2fC[256] = { | |||
There was a problem hiding this comment.
dqm doesn't seem like the place we should be defining adc2fC. I guess this is already done elsewhere?
|
@davidlange6 this array is for QIE10. As Phase 1 is in dev stage, I've included that in here, but it's used only for Onliny DQM |
|
we seem to have similar yet different arrays defined for qie10 elsewhere? no?
|
|
@davidlange6 , these updates went into Online DQM quite a while ago and PR with this array has been submitted long time ago. Regarding if it's defined anyelse, I don't know. Since RECO has not been fully developed yet for Phase1, which is where this array will only be used, I included that in the release - but it will be removed once Phase soft is fully deved. VK |
|
Concerning adc2FC conversion for QIE10: (1) "coder" prepared (generic piece both for QIE8/QIE10, as QIE8/QIE10 comes from HcalQIETypes in DB and defines QIE shape for concrete DetId "behind the scene"): (2) Adding NB: this is for possible future usage, I'm not suggesting to implement it to case even more approval delay for this PR... |
|
a new one is preped #15380 closing |
cherry-picked from 80X commits from 14742
There are no significant updates, all of them are either tweaking some thresholds or some requests of parameter tweaking:
V