remove unnecessary cloning of particleFlowDisplacedVertex and pfCandidateToVertexAssociation in met corrections #14744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation in producePatPFMETCorrections and patPFMetT0CorrSequence postfix
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_1_X. It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
davidlange6
added a commit
that referenced
this pull request
Jun 24, 2016
…ETPF remove unnecessary cloning of particleFlowDisplacedVertex and pfCandidateToVertexAssociation in met corrections (backport of #14744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modules with (currently) identical PSets independent of MET correction settings were cloned unnecessarily: particleFlowDisplacedVertex and pfCandidateToVertexAssociation were cloned to
*Puppi and *NoHF instances.
The extra CPU consumed by these in PU35 ttbar MC is about 3% of total event processing time.
If future implementations need these to be different, cloning of these modules can be re-enabled.
If there was no lingering need to support scheduled execution and if these modules were not in endpaths,
a solution could have been easier (just drop from the original sequence definition).
No changes in final results are expected (none were observed in local tests)