New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RPCGeometryBuilder to set correct chamber surface #14848
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b8a8139
code cleanup minor speedup using set
jhgoh 06d1d0b
constify variables
jhgoh 19f6ecf
constify and cleanup
jhgoh 0ef3692
compute RPCChamber bounds by envelope of all rolls
jhgoh bbd4719
should be half height
jhgoh 58c632c
should be half height
jhgoh 6725764
typo
jhgoh ec40e57
thickness from Z difference
jhgoh File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
#include <CondFormats/GeometryObjects/interface/RecoIdealGeometry.h> | ||
#include <string> | ||
#include <map> | ||
#include <list> | ||
#include <set> | ||
|
||
|
||
class RPCGeometry; | ||
|
@@ -30,7 +30,7 @@ class RPCGeometryBuilderFromCondDB | |
|
||
|
||
private: | ||
std::map<RPCDetId,std::list<RPCRoll *> > chids; | ||
std::map<RPCDetId,std::set<RPCRoll *> > chids; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. randomizes the order of RPCRoll between jobs or IOVs |
||
bool theComp11Flag; | ||
|
||
}; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the higher (above 0) indices intentionally uninitialized?
You will likely get values from the previous calls in cornersLo[1, 2] etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are initialized to be zero by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are they initialized to zero?
float cornersZ[2] = {0,}
only sets the cornersZ[0]