Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add timing VS lumi (for HLT monitoring) #14938

Closed
wants to merge 3,826 commits into from
Closed

add timing VS lumi (for HLT monitoring) #14938

wants to merge 3,826 commits into from

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jun 21, 2016

back port of #14937

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Jun 21, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X.

It involves the following packages:

DQM/HLTEvF
DQM/TrackingMonitor
HLTrigger/Timer

@perrotta, @cmsbuild, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @threus, @fioriNTU this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

fwyzard
fwyzard reviewed Jun 21, 2016
View reviewed changes
DQM/HLTEvF/plugins/LumiMonitor.cc

{

folderName_ = conf_.getParameter<std::string>("FolderName");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move folderName_, pixelClustersToken_ and lumiscalersToken_ to the initialisation as well ?

@fwyzard fwyzard mentioned this pull request Jun 22, 2016
Merged
@davidlange6
Merge pull request cms-sw#15121 from leggat/pixel-cluster-trend-plots
90babc7 
Implementing pixel cluster trend plots
@davidlange6
Merge pull request cms-sw#15113 from argiro/ecalOptionNoTimeCalib
0f262f9 
add option to switch off time calibration 81x
@davidlange6
Merge pull request cms-sw#15110 from ianna/tk-reco-material-2017
edb3be1 
Tracker Reco Material for 2017 Scenario
@davidlange6
Merge pull request cms-sw#15097 from ghellwig/phase1_alignment-update…
a74970d 
…s_81X

Phase-1 alignment updates
@davidlange6
Merge pull request cms-sw#15024 from gartung/Calibration-Tools-fix-in…
09ebf39 
…dent-not-guard

Calibration/Tools : formatting fix for gcc 6.0 misleading-indentation warning
@davidlange6
Merge pull request cms-sw#15003 from gartung/RecoTracker-MeasurementD…
b64a650 
…et-fix-indent-not-guard-warn

RecoTracker/MeasurementDet : bug fix for gcc 6.0 misleading-indentation warning
@davidlange6
Merge pull request cms-sw#14994 from ebrondol/fixDuplicate_ph2Tracking
042435f 
Reducing duplicates in Phase2 tracking reconstruction (with some minor effects on phase0/1 tracking)
@davidlange6
Merge pull request cms-sw#14843 from matt-komm/hitmerging-master
03041ec 
New FastSim Hit Reconstruction Emulation
@davidlange6
Merge pull request cms-sw#15128 from ianna/fix-edm-ml-debug-compilation
821338b 
Fix Compilation Errors with EDM_ML_DEBUG Defined
@cmsbuild
Copy link
Contributor

Pull request #14938 was updated. @ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #14938 was updated. @ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@mtosi
Copy link
Contributor Author

mtosi commented Jul 12, 2016

sorry the confusion (and mess as well)

I think I have to close and open a new PR
because re-basing the timingVSlumi branch for 81x
this PR gets spoiled :(

do you agree ?
I mean, are there other smarter ways ?
thanks

@slava77 @Dr15Jones @davidlange6

@mtosi mtosi mentioned this pull request Jul 12, 2016
Merged
@dmitrijus
Copy link
Contributor

You don't have to create a new pull request - just do a forced push (git push -f) after a rebase.
But whichever you decide, please close this or the other pull request.

@mtosi
Copy link
Contributor Author

mtosi commented Jul 12, 2016

as said I had issue w/ the synch of the branch in 81x and 80x
=> I opened the PR #15169
=> close this one
sorry the confusion and thanks

@mtosi mtosi closed this Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending analysis-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet