New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hltDiff: fix comparison of trigger candidates with different process name #15012
hltDiff: fix comparison of trigger candidates with different process name #15012
Conversation
…d and new collections have a different process name
+1 |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_8_0_X. It involves the following packages: HLTrigger/Tools @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@davidlange6 , could you pick this up for the next 8.0.x release as well ? |
-1 Tested at: b7dfc04 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log50202.0 step3 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log4.22 step1 DAS Error140.53 step1 DAS Error |
please test
|
hltDiff is not used in any workflow (yet), please disregard the failures
|
The tests are being triggered in jenkins. |
+1 |
fix the comparison of the trigger candidates when the old and new collections have a different process name