Implementing pixel cluster trend plots #15120
Conversation
|
A new Pull Request was created by @leggat for CMSSW_8_0_X. It involves the following packages: DQM/SiPixelMonitorCluster @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| ss1.str(std::string()); ss1 << "totalNumberOfClustersProfile_siPixelClusters_Barrel"; | ||
| ss2.str(std::string()); ss2 << "Total number of barrel clusters profile;Lumisection;"; | ||
| meClusBarrelProf = iBooker.bookProfile(ss1.str(),ss2.str(),2400,0.,150,0,0,""); | ||
| meClusBarrelProf->getTH1()->SetCanExtend(TH1::kAllAxes); |
There was a problem hiding this comment.
Is it possible not to use SetCanExtend? It does cause performance problems. And who knows what other issues in the future.
There was a problem hiding this comment.
We already had this discussion in 81x... sorry.
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 Tested at: 446971c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests RelVals AddOn
I found errors in the following unit tests:
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log4.22 step1 DAS Error1000.0 step1 DAS Error1001.0 step1 DAS Error
I found errors in the following addon tests: cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_X_2016-07-10-0000/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Tue Jul 12 18:44:20 2016-date Tue Jul 12 18:44:10 2016 s - exit: 23552 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison is ready The workflows 1001.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1 |
Lumisection based cluster trend plots for the barrel and endcap of the pixel detector DQM