Switch FastCircleFit to use Eigen, generalize FastCircleFit and RZLine interfaces #15260
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| #ifndef PixelTrackFitting_RZLine_H | ||
| #define PixelTrackFitting_RZLine_H | ||
|
|
||
| #include "DataFormats/GeometryVector/interface/GlobalPoint.h" | ||
| #include "DataFormats/GeometryCommonDetAlgo/interface/GlobalError.h" | ||
| #include "CommonTools/Utils/interface/DynArray.h" | ||
|
|
||
| #include "CommonTools/Statistics/interface/LinearFit.h" | ||
|
|
||
| #include <vector> | ||
|
|
||
| class RZLine { | ||
| public: | ||
| struct ErrZ2_tag {}; | ||
|
|
||
| /** | ||
| * Constructor for containers of GlobalPoint, GlobalError, and bool | ||
| * | ||
| * @tparam P Container of GlobalPoint | ||
| * @tparam E Container of GlobalError | ||
| * @tparam B Container of bool | ||
| * | ||
| * Container can be e.g. std::vector, std::array, or DynArray. | ||
| * | ||
| * Although for std::array use this constructor could be specialized | ||
| * to use std::array instead of DynArray for temporary storage. | ||
| */ | ||
| template <typename P, typename E, typename B> | ||
| RZLine(const P& points, const E& errors, const B& isBarrel) { | ||
| const size_t n = points.size(); | ||
| declareDynArray(float, n, r); | ||
| declareDynArray(float, n, z); | ||
| declareDynArray(float, n, errZ2); | ||
| for(size_t i=0; i<n; ++i) { | ||
| const GlobalPoint& p = points[i]; | ||
| r[i] = p.perp(); | ||
| z[i] = p.z(); | ||
| } | ||
|
|
||
| float simpleCot2 = sqr( (z[n-1]-z[0])/ (r[n-1]-r[0]) ); | ||
| for (size_t i=0; i<n; ++i) { | ||
| errZ2[i] = (isBarrel[i]) ? errors[i].czz() : | ||
| errors[i].rerr(points[i]) * simpleCot2; | ||
| } | ||
|
|
||
| calculate(r, z, errZ2); | ||
| } | ||
|
|
||
| /** | ||
| * Constructor for std::vector of r, z, and z standard deviation | ||
| */ | ||
| RZLine(const std::vector<float> & r, | ||
| const std::vector<float> & z, | ||
| const std::vector<float> & errZ) { | ||
| const size_t n = errZ.size(); | ||
| declareDynArray(float, n, errZ2); | ||
| for(size_t i=0; i<n; ++i) errZ2[i] = sqr(errZ[i]); | ||
| calculate(r, z, errZ2); | ||
| } | ||
|
|
||
| /** | ||
| * Constructor for std::array of r, z, and z standard deviation | ||
| */ | ||
| template <size_t N> | ||
| RZLine(const std::array<float, N>& r, | ||
| const std::array<float, N>& z, | ||
| const std::array<float, N>& errZ) { | ||
| std::array<float, N> errZ2; | ||
| for(size_t i=0; i<N; ++i) errZ2[i] = sqr(errZ[i]); | ||
| calculate(r, z, errZ2); | ||
| } | ||
|
|
||
| /** | ||
| * Constructor for container of r, z, and z variance | ||
| * | ||
| * @tparam T Container of float | ||
| * | ||
| * Container can be e.g. std::vector, std::array, or DynArray. | ||
| * | ||
| * The ErrZ2_tag parameter is used to distinguish this constructor | ||
| * from other 3-parameter constructors. | ||
| * | ||
| * Passing variance is useful in cases where it is already available | ||
| * to avoid making a square of a square root. | ||
| */ | ||
| template <typename T> | ||
| RZLine (const T& r, const T& z, const T& errZ2, ErrZ2_tag) { | ||
| calculate(r, z, errZ2); | ||
| } | ||
|
|
||
| float cotTheta() const { return cotTheta_; } | ||
| float intercept() const { return intercept_; } | ||
| float covss() const { return covss_; } | ||
| float covii() const { return covii_; } | ||
| float covsi() const { return covsi_; } | ||
|
|
||
| float chi2() const { return chi2_; } | ||
|
|
||
| private: | ||
| template <typename R, typename Z, typename E> | ||
| void calculate(const R& r, const Z& z, const E& errZ2) { | ||
| const size_t n = r.size(); | ||
| linearFit(r.data(), z.data(), n, errZ2.data(), cotTheta_, intercept_, covss_, covii_, covsi_); | ||
| chi2_ = 0.f; | ||
| for(size_t i=0; i<n; ++i) { | ||
| chi2_ += sqr( ((z[i]-intercept_) - cotTheta_*r[i]) ) / errZ2[i]; | ||
|
There was a problem hiding this comment. How safe is this division? Could unusual circumstances cause There was a problem hiding this comment. (Note that this code is exactly as before) In practice |
||
| } | ||
| } | ||
|
|
||
| template <typename T> | ||
| T sqr(T t) { return t*t; } | ||
|
|
||
| float cotTheta_; | ||
| float intercept_; | ||
| float covss_; | ||
| float covii_; | ||
| float covsi_; | ||
| float chi2_; | ||
| }; | ||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a division by zero possibility here if
(r[n-1]-r[0]) == 0? Or would that be prevented from happening? Or would it take too long to check for the zero value?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Note that this code is exactly as before) I guess it could, in principle, happen that the first and last hit would have exactly the same
r, if all hits come from FPix/TID/TEC. But I'd expect this situation to be very unlikely, especially given the constraints of seeds to point towards beamspot (even if loosely on strip-triplet steps).