Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: directory rename Totem -> CTPPS (back-port of #15311) #15317

Merged
merged 11 commits into from Aug 9, 2016

Conversation

jan-kaspar
Copy link
Contributor

Several "Totem" directories renamed to simplify code sharing with other CTPPS detectors.

This is a back-port of #15311, see details there.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jan-kaspar for CMSSW_8_0_X.

It involves the following packages:

CondFormats/CTPPSReadoutObjects
Configuration/StandardSequences
DQM/CTPPS
DQM/Integration
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
EventFilter/CTPPSRawToDigi
EventFilter/TotemRawToDigi
Geometry/VeryForwardGeometryBuilder
RecoCTPPS/Configuration
RecoCTPPS/TotemRPLocal

The following packages do not have a category, yet:

CondFormats/CTPPSReadoutObjects
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
EventFilter/CTPPSRawToDigi

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @franzoni, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @batinkov, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14278/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Jul 29, 2016

+1

@cvuosalo
Copy link
Contributor

+1

For #15317 77d408a

Renaming TOTEM directories for CT-PPS. There should be no change in monitored quantities.

#15311 is the 81X version of this PR, and it has already been approved by Reco.

The changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-07-28-1100 show no significant differences, as expected.

@dmitrijus
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants