Subjet TagInfo updates #15331
Subjet TagInfo updates #15331
Conversation
…ut intermediate groomed fat jets
|
A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_8_1_X. It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
ferencek
force-pushed
the
SubjetTagInfosNoClustering-PR_from-CMSSW_8_1_0_pre9
branch
from
518c455
to
874a937
Compare
| edm::Ptr<reco::Jet> jetPtr = jets->ptrAt(idx); | ||
| Jet ajet( edm::RefToBase<Jet>(jetRef.castTo<JetRef>()) ); | ||
| const Jet * origJet = dynamic_cast<const Jet *>( jetRef.get() ); | ||
| Jet ajet( *origJet ); |
There was a problem hiding this comment.
For my understanding only: can you explain the reason for these changes?
There was a problem hiding this comment.
Does this preserve the existing UserFloats in a PAT jet, when updated?
There was a problem hiding this comment.
@mverzett: If a pat::Jets is constructed from an object reference, then this newly created pat::Jet will be pointing to this object from which it was constructed. This is quite bad when using the updateJetCollection() function because every updated pat::Jet will lose memory of the original object it was derived from. This is particularly relevant for fat jets and subjets. If you decided to update either fat jets or subjets, you will no longer be able to figure out which subjet belongs to which fat jet.
@ahinzmann: Yes.
|
@ferencek: Could you please provide me a test config so I can verify the operation of the new features? |
ferencek
force-pushed
the
SubjetTagInfosNoClustering-PR_from-CMSSW_8_1_0_pre9
branch
from
874a937
to
d3f9d0a
Compare
|
Pull request #15331 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
@cvuosalo, I added an |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| { | ||
| const pat::Jet * subJet = dynamic_cast<const pat::Jet *>( subjets->at(sj).jet().get() ); | ||
| if( !subJet ) | ||
| edm::LogError("WrongJetType") << "Wrong jet type for input subjets. Please check that the input subjets are of the pat::Jet type."; |
There was a problem hiding this comment.
After this line, there needs to be a break; or else if...; otherwise there could be a segmentation fault.
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #15331 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
@cvuosalo, thanks for the comment. I push a new commit that should improve handling of wrong input jet types. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 Analysis-level enhancement of subjet TagInfos for the SV TagInfo producer. There should be no change in monitored quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-08-1100 show no significant differences, as expected. A new unit test is included in the PR to test the new features, and the test in Jenkins is successful. |
ferencek
deleted the
SubjetTagInfosNoClustering-PR_from-CMSSW_8_1_0_pre9
branch
This PR adds new features to the SV TagInfo producer that allow making subjet TagInfos using simple cone-based instead of ghost association to fat jets. The code now also makes it possible to perform such association using PATified fat jets and subjets. To fully exploit this last feature it was necessary to update the PATJetUpdater so that PAT jets are cloned (not constructed from a reference) in order to preserve the reference to the original object the PAT jet was derived from (this is necessary for re-establishing references between updated PAT fat jets and subjets). Finally, minor changes were added to jetTools.py to properly configure the updated SV TagInfo producer.
This is purely an analysis level update. There should be no impact on the standard reconstruction or MiniAOD production.