New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CastorBaseMonitor module removed, cleaning the rest Castor DQM modules #15350
Conversation
A new Pull Request was created by @popovvp for CMSSW_8_1_X. It involves the following packages: DQM/CastorMonitor @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@@ -14,22 +14,24 @@ | |||
//======================= Constructor ==============================// | |||
CastorRecHitMonitor::CastorRecHitMonitor(const edm::ParameterSet& ps) | |||
{ | |||
std::cout<<"CastorRecHitMonitor Constructor: "<<this<<std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this line.
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
@popovvp - please update the title of this PR with a meaningful description for the release notes. Thanks. (eg, a bug fix in what part of cmssw?) |
+1 |
removed subFolder CastorEventProducts (Event Products plots moved to "Castor" subFolder
removed CastorBaseMonitor module
removed obsolete stuff from Castor modules
fixed bug in jet access