Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove HcalCovarianceMatrix object entirely #15363

Merged

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Aug 3, 2016

While preparing #15320, I noticed that HcalCovarianceMatrix was also entirely unused. This command gives no results at all:

conddb search HcalCovarianceMatrices

and there is no code outside of AlCA/DB areas that has any dependence on these objects.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2016

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
CondCore/HcalPlugins
CondFormats/DataRecord
CondFormats/HcalObjects
CondTools/Hcal

@ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mariadalfonso, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 3, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14346/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2016

-1

Tested at: d654f7e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15363/14346/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 4, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2016

-1

Tested at: d654f7e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15363/14354/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 5, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14385/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2016

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 5, 2016

@mmusich @ggovi please approve whenever you can, this one should also be harmless

@mmusich
Copy link
Contributor

mmusich commented Aug 7, 2016

+1

@davidlange6 davidlange6 merged commit 7ed8a49 into cms-sw:CMSSW_8_1_X Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants