New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove HcalCovarianceMatrix object entirely #15363
remove HcalCovarianceMatrix object entirely #15363
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: CalibCalorimetry/HcalAlgos @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: d654f7e You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: d654f7e You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
While preparing #15320, I noticed that HcalCovarianceMatrix was also entirely unused. This command gives no results at all:
and there is no code outside of AlCA/DB areas that has any dependence on these objects.