Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove HcalCholeskyMatrix object entirely #15320

Merged
merged 2 commits into from Aug 3, 2016
Merged

remove HcalCholeskyMatrix object entirely #15320

merged 2 commits into from Aug 3, 2016

Conversation

kpedro88
Copy link
Contributor

This PR finishes the removal of the unused HcalCholeskyMatrix object (see issue #14954).

attn: @abdoulline

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Jul 28, 2016
@kpedro88 kpedro88 mentioned this pull request Jul 28, 2016
Closed
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CondCore/HcalPlugins
CondCore/Utilities
CondFormats/HcalObjects

@ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 28, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14272/console

@cmsbuild
Copy link
Contributor

Pull request #15320 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: 9b660b8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15320/14272/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15320/14272/summary.html

@mmusich
Copy link
Contributor

mmusich commented Jul 28, 2016

+1

@kpedro88
Copy link
Contributor Author

@ggovi @davidlange6 it would be nice to merge this quickly - while preparing this, I noticed another unused HCAL CondFormat that can be removed (HcalCovarianceMatrix). However, because that object has neighboring lines of code with HcalCholeskyMatrix in some places, I have to wait until this PR is merged so I can rebase. Otherwise, Git thinks there is a conflict.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 1, 2016

@ggovi ping

@mmusich
Copy link
Contributor

mmusich commented Aug 2, 2016 •
edited

@kpedro88
@ggovi is away for a few days, and I am not sure he's reading us.
I think this PR is harmless enough to be merged by-passing the db signature. Let's discuss it at today's ORP.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 2, 2016

@mmusich I hope you mean harmless...

@mmusich
Copy link
Contributor

mmusich commented Aug 2, 2016

@kpedro88 freudian slip :) corrected now

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 2, 2016

@davidlange6 reminder

@davidlange6 davidlange6 merged commit 38e3657 into cms-sw:CMSSW_8_1_X Aug 3, 2016
@kpedro88 kpedro88 mentioned this pull request Aug 3, 2016
Merged
@slava77 slava77 mentioned this pull request Aug 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available db-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kpedro88 @cmsbuild @mmusich @davidlange6