HIP Killing and PreMixing for 81X

[mdhildreth]

Version of SiStripDigitizer with HIP APV killing implemented in a way that is consistent with MC production (luminosity variation) and PreMixing.

[cmsbuild]

A new Pull Request was created by @mdhildreth for CMSSW_8_1_X.

It involves the following packages:

DataFormats/StdDictionaries
DataFormats/WrappedStdDictionaries
SimGeneral/Configuration
SimGeneral/DataMixingModule
SimGeneral/MixingModule
SimTracker/SiPixelDigitizer
SimTracker/SiStripDigitizer

@smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@wmtan, @makortel, @sdevissc, @GiacomoSguazzoni, @jlagram, @rovere, @VinInn, @cnuttens, @prolay, @dkotlins, @wddgit, @threus, @dgulhan, @LBeck this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[mdhildreth]

Please don't review yet. Just spotted a couple of points for cleanup

[cmsbuild]

Pull request #15436 was updated. @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[mdhildreth]

Ok, this should be the final version

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14486/console

[Dr15Jones]

+1
Core related changes are just adding more std:: based data products using builtin types.

[mdhildreth]

please test

[cmsbuild]

Pull request #15436 was updated. @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14510/console

[mdhildreth]

@VinInn I think the Analyzer is outside my scope on this one...

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: 9bde39c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15436/14510/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

--- Registered EDM Plugin: SimTrackerSiStripDigitizerPlugins
>> Leaving Package SimTracker/SiStripDigitizer
>> Package SimTracker/SiStripDigitizer built
>> Subsystem SimTracker built
tmp/slc6_amd64_gcc530/src/SimGeneral/DataMixingModule/plugins/SimGeneralDataMixingModulePlugins/DataMixingModule.o:(.data.rel.ro._ZTVN3edm16DataMixingModuleE[_ZTVN3edm16DataMixingModuleE]+0x90): undefined reference to `edm::DataMixingModule::checkSignal(edm::Event const&)'
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc530/src/SimGeneral/DataMixingModule/plugins/SimGeneralDataMixingModulePlugins/libSimGeneralDataMixingModulePlugins.so] Error 1
Leaving library rule at src/SimGeneral/DataMixingModule/plugins
>> Leaving Package SimGeneral/DataMixingModule
>> Package SimGeneral/DataMixingModule built
>> Subsystem SimGeneral built


[mdhildreth]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14512/console

[cmsbuild]

Pull request #15436 was updated. @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[cmsbuild]

+1
Tested at: cbd88c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15436/14512/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15436/14512/summary.html

[mdhildreth]

+1