Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jets for 81x MiniAOD #15437

Merged
merged 7 commits into from Aug 29, 2016
Merged

Jets for 81x MiniAOD #15437

merged 7 commits into from Aug 29, 2016

Conversation

rappoccio
Copy link
Contributor

Here are the changes for Jets for 81x MiniAOD. The changes are:

  • We are "switching" from CHS to PUPPI in AK8 jets. Previously we stored CHS jets and matched PUPPI to those objects, storing values in user floats. Now we store PUPPI jets and store CHS values in user floats instead.
  • We dropped the CHS subjets, saving about 0.5% of the event size.
  • We added a single b-tagging discriminator to the subjets.

Tests ran: runTheMatrix.py -l limited -i all -j 10, scram b runtests

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_8_1_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @gpetruc, @mmarionncern, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Aug 11, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14487/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Aug 18, 2016

Here are some plots to go with the changes, based on T1tttt with mglu= 1.5TeV mLSP=100 GeV; from RECO of RelVal 810pre9

jet raw PT is slightly lower

wft1tttt_ak8_ptrecogen_100to500

but response after correction is essentially the same

wft1tttt_ak8_corrogen_b

Jet mass response is lower ... I didn't find a "corrected" mass plot
wft1tttt_ak8_ptrecogen_100to500

PLots with prunedMass, softdrop and tau* are empty.
Unclear if DQM needs an update or the plots just migrated to different category
wft1tttt_ak8_prunedmass

wft1tttt_ak8_softdropmass

wft1tttt_ak8_tau2otau1

On the technical side:

  • AK8CHS and upstream and downstream modules in PAT are gone (36 of them);
  • AK8Puppi jets and related modules were added (27 total)
  • event content doesn't have patJets_slimmedJetsAK8PFCHSSoftDropPacked_SubJets anymore (as expected), which is about 0.5%

Please check and confirm that the DQM plots behavior is OK. (I suspect something is missing)

@slava77
Copy link
Contributor

slava77 commented Aug 18, 2016

@rappoccio @schoef @jdolen @ahinzmann
Do you intend to make the same change for 2016 data rereco?
If so, a PR for 80X is needed.

@slava77
Copy link
Contributor

slava77 commented Aug 19, 2016

I'm waiting for feedback on #15437 (comment)
before I can sign.

@ahinzmann
Copy link
Contributor

we are not planning to backport to 80 (since 80 contains both CHS and PUPPI anyways already).
For the DQM plots @rappoccio will comment.

@rappoccio
Copy link
Contributor Author

Hi, Folks,

Sorry for the delay, I was on holiday.

We will indeed probably not backport to 80x unless there is a strong desire. About the DQM, indeed I did not change those, I will need to do that. Give me a few hours.

Cheers,
Sal

@slava77
Copy link
Contributor

slava77 commented Aug 24, 2016

Hi Sal,

a few hours later there is no update yet.
Please clarify on the timeline.
It would be better to make the change in time for pre11 (a PR update today-ish with a chance to check/fix left)

@rappoccio
Copy link
Contributor Author

Yes, sorry, I will try my best to get this done today.

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2016

@rappoccio
you mentioned yesterday that some fixes were still in line.
Please clarify if/when they are coming.

@cmsbuild
Copy link
Contributor

Pull request #15437 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @montjj, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2016

@rappoccio
please leave a note to clarify that all changes from you are included
Thanks.

@cmsbuild
Copy link
Contributor

Pull request #15437 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @montjj, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

@rappoccio
Copy link
Contributor Author

Right now! Found the problem. The plots are as follows:

tau21.pdf
softdropmass.pdf
ptuncorr.pdf
prunedmass.pdf

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14762/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Aug 27, 2016

+1

for #15437 dc8a0bb

  • changes since 2667ff2 are as expected, based on the SMS relval test:
    • reco quantities are unchanged
    • DQM plots are recovered: SoftDrop, Pruned, and tauX.over.tauY are now filled and appear to be in reasonable agreement
  • jenkins tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants