New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching BoostedDoubleSV tagger to v3 training #15445
Switching BoostedDoubleSV tagger to v3 training #15445
Conversation
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_8_1_X. It involves the following packages: RecoBTag/SecondaryVertex @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
@ferencek |
@@ -6,9 +6,9 @@ | |||
trackSelectionBlock, | |||
beta = cms.double(1.0), | |||
R0 = cms.double(1.5), | |||
maxSVDeltaRToJet = cms.double(1.3), | |||
maxSVDeltaRToJet = cms.double(1.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change does not look strongly related to the training version.
It would be worth to mention it in the PR description, if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends how you look at it. The new training was done with a reduced cut value, it also had to be changed in the release.
I updated the PR description.
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
The updated training was announced in slide 7 of the News slides in the b tag meeting during the June CMS Week (https://indico.cern.ch/event/543002/contributions/2205056/attachments/1295645/1932587/BTV_news_2016_06_21.pdf).
The performance is slightly improved wrt the old training v2 training produced in the 74X release cycle. In addition, for CA15 jets the dR(SV,jet) cut used to associated secondary vertices to jets was reduced from 1.3 to 1.0 in order to reduce the fake rate and consequently improve the overall performance.