Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching BoostedDoubleSV tagger to v3 training #15445

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Aug 12, 2016

The updated training was announced in slide 7 of the News slides in the b tag meeting during the June CMS Week (https://indico.cern.ch/event/543002/contributions/2205056/attachments/1295645/1932587/BTV_news_2016_06_21.pdf).

The performance is slightly improved wrt the old training v2 training produced in the 74X release cycle. In addition, for CA15 jets the dR(SV,jet) cut used to associated secondary vertices to jets was reduced from 1.3 to 1.0 in order to reduce the fake rate and consequently improve the overall performance.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_8_1_X.

It involves the following packages:

RecoBTag/SecondaryVertex

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Aug 12, 2016

@cmsbuild please test
looks like the files are in the IB already

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14498/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15445/14498/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1

@slava77
Copy link
Contributor

slava77 commented Aug 17, 2016

@ferencek
for self-documentation, please add a link to slides that describe performance changes.
I suppose, this PR was discussed in the POG meeting already.

@@ -6,9 +6,9 @@
trackSelectionBlock,
beta = cms.double(1.0),
R0 = cms.double(1.5),
maxSVDeltaRToJet = cms.double(1.3),
maxSVDeltaRToJet = cms.double(1.0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change does not look strongly related to the training version.
It would be worth to mention it in the PR description, if so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends how you look at it. The new training was done with a reduced cut value, it also had to be changed in the release.

I updated the PR description.

@slava77
Copy link
Contributor

slava77 commented Aug 17, 2016

+1

for #15445 7e49509

  • code changes are in line with the PR title; a tagger used for AK8 jets in miniAOD and for CA 1.5 for analysis are updated
  • jenkins tests pass and comparisons with baseline show no differences (the values in pfBoostedDoubleSecondaryVertexAK8BJetTagsAK8 are not monitored)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit aa5398c into cms-sw:CMSSW_8_1_X Aug 18, 2016
@ferencek ferencek deleted the BoostedDoubleSVTaggerV3-PR_from-CMSSW_8_1_X_2016-08-10-1100 branch August 24, 2016 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants