New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip the soft lepton sIP in case the Negative CTagger is used #15478
Flip the soft lepton sIP in case the Negative CTagger is used #15478
Conversation
A new Pull Request was created by @smoortga for CMSSW_8_1_X. It involves the following packages: RecoBTag/CTagging @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Allow sign flipping of the softElectron and softMuon impact parameters for the negative c tagger. There should be no change in monitored RECO quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-16-1100 show no significant differences, as expected. |
@monttj: You might want to take a look at this PR. It concerns c tagging. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
@cvuosalo thank you for letting me know |
Indeed, I did a quick check and the Normal and Positive taggers are unaffected, small changes are observed in the negative tag distributions as expected, but no chocking differences. But still it would be nice to see how it affects the negative tag method for SF_light determination. |
This PR introduces the possibility to also flip the softElectron and softMuon impact parameter sign in case the negative c-tagger is used. The boolian is by default set to false (no other b-taggers are affected by this), but it is set to true in case the negative c-tagger is used.
@mverzett and @kovitang are interested in following this PR