Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip the soft lepton sIP in case the Negative CTagger is used #15478

Merged

Conversation

smoortga
Copy link
Contributor

This PR introduces the possibility to also flip the softElectron and softMuon impact parameter sign in case the negative c-tagger is used. The boolian is by default set to false (no other b-taggers are affected by this), but it is set to true in case the negative c-tagger is used.

@mverzett and @kovitang are interested in following this PR

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smoortga for CMSSW_8_1_X.

It involves the following packages:

RecoBTag/CTagging
RecoBTag/SecondaryVertex

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Aug 16, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14541/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #15478 f8b6d57

Allow sign flipping of the softElectron and softMuon impact parameters for the negative c tagger. There should be no change in monitored RECO quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-16-1100 show no significant differences, as expected.

@cvuosalo
Copy link
Contributor

@monttj: You might want to take a look at this PR. It concerns c tagging.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@monttj
Copy link
Contributor

monttj commented Aug 18, 2016

@cvuosalo thank you for letting me know
I would be curious if this flipping will change the discriminator distribution?
e.g. pfCombinedCvsLJetTags, pfCombinedCvsBJetTags

@kovitang
Copy link
Contributor

@monttj and @cvuosalo The flipping will only affect the
pfNegativeCombinedCvsLJetTags and pfNegativeCombinedCvsBJetTags

@smoortga
Copy link
Contributor Author

Indeed, I did a quick check and the Normal and Positive taggers are unaffected, small changes are observed in the negative tag distributions as expected, but no chocking differences. But still it would be nice to see how it affects the negative tag method for SF_light determination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants